[coreboot-gerrit] Change in coreboot[master]: amd/stoneyridge: Rearrange southbridge.h

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29013 )

Change subject: amd/stoneyridge: Rearrange southbridge.h
......................................................................


Patch Set 2:

(4 comments)

https://review.coreboot.org/#/c/29013/2/src/soc/amd/stoneyridge/include/soc/southbridge.h
File src/soc/amd/stoneyridge/include/soc/southbridge.h:

https://review.coreboot.org/#/c/29013/2/src/soc/amd/stoneyridge/include/soc/southbridge.h@131
PS2, Line 131: #define   CG1PLL_SS_STEP_SIZE_DSFRAC_MASK	(0xffff << CG1PLL_SS_STEP_SIZE_DSFRAC_SHIFT)
line over 80 characters


https://review.coreboot.org/#/c/29013/2/src/soc/amd/stoneyridge/include/soc/southbridge.h@133
PS2, Line 133: #define   CG1PLL_SS_AMOUNT_DSFRAC_MASK		(0xffff << CG1PLL_SS_AMOUNT_DSFRAC_SHIFT)
line over 80 characters


https://review.coreboot.org/#/c/29013/2/src/soc/amd/stoneyridge/include/soc/southbridge.h@136
PS2, Line 136: #define   CG1PLL_SS_AMOUNT_NFRAC_SLIP_MASK	(0xf << CG1PLL_SS_AMOUNT_NFRAC_SLIP_SHIFT)
line over 80 characters


https://review.coreboot.org/#/c/29013/2/src/soc/amd/stoneyridge/include/soc/southbridge.h@166
PS2, Line 166: #define   DEBUG_PORT_MASK		(BIT(16) | BIT(17) | (BIT(18))
Macros with complex values should be enclosed in parentheses



-- 
To view, visit https://review.coreboot.org/29013
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6ef21431db0e758eba0ea043b54c036ec6235fe
Gerrit-Change-Number: 29013
Gerrit-PatchSet: 2
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 12 Oct 2018 15:17:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181012/c17e2258/attachment.html>