<p><a href="https://review.coreboot.org/29013">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29013/2/src/soc/amd/stoneyridge/include/soc/southbridge.h">File src/soc/amd/stoneyridge/include/soc/southbridge.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29013/2/src/soc/amd/stoneyridge/include/soc/southbridge.h@131">Patch Set #2, Line 131:</a> <code style="font-family:monospace,monospace">#define   CG1PLL_SS_STEP_SIZE_DSFRAC_MASK   (0xffff << CG1PLL_SS_STEP_SIZE_DSFRAC_SHIFT)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29013/2/src/soc/amd/stoneyridge/include/soc/southbridge.h@133">Patch Set #2, Line 133:</a> <code style="font-family:monospace,monospace">#define   CG1PLL_SS_AMOUNT_DSFRAC_MASK         (0xffff << CG1PLL_SS_AMOUNT_DSFRAC_SHIFT)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29013/2/src/soc/amd/stoneyridge/include/soc/southbridge.h@136">Patch Set #2, Line 136:</a> <code style="font-family:monospace,monospace">#define   CG1PLL_SS_AMOUNT_NFRAC_SLIP_MASK        (0xf << CG1PLL_SS_AMOUNT_NFRAC_SLIP_SHIFT)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29013/2/src/soc/amd/stoneyridge/include/soc/southbridge.h@166">Patch Set #2, Line 166:</a> <code style="font-family:monospace,monospace">#define   DEBUG_PORT_MASK                (BIT(16) | BIT(17) | (BIT(18))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Macros with complex values should be enclosed in parentheses</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/29013">change 29013</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29013"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ia6ef21431db0e758eba0ea043b54c036ec6235fe </div>
<div style="display:none"> Gerrit-Change-Number: 29013 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 12 Oct 2018 15:17:21 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>