[coreboot-gerrit] Change in coreboot[master]: mb/lenovo/*/romstage: Use macros instead of magic numbers
Peter Lemenkov (Code Review)
gerrit at coreboot.org
Fri Oct 12 08:44:25 CEST 2018
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/28976
to look at the new patch set (#3).
Change subject: mb/lenovo/*/romstage: Use macros instead of magic numbers
......................................................................
mb/lenovo/*/romstage: Use macros instead of magic numbers
Apparently coreboot still uses magic numbers instead of macros in some
Lenovo mainboards. Let's use macros instead.
Also removed some board names from comments since these functions
sometimes are very similar, so no need to add extra difference between
them.
Change-Id: I6468e3357f8eed434f8527a852e134380f486d9a
Signed-off-by: Peter Lemenkov <lemenkov at gmail.com>
---
M src/mainboard/lenovo/l520/romstage.c
M src/mainboard/lenovo/s230u/romstage.c
M src/mainboard/lenovo/t520/romstage.c
M src/mainboard/lenovo/t530/romstage.c
M src/mainboard/lenovo/x1_carbon_gen1/romstage.c
M src/mainboard/lenovo/x201/romstage.c
M src/mainboard/lenovo/x220/romstage.c
M src/mainboard/lenovo/x230/romstage.c
8 files changed, 26 insertions(+), 21 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/28976/3
--
To view, visit https://review.coreboot.org/28976
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6468e3357f8eed434f8527a852e134380f486d9a
Gerrit-Change-Number: 28976
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Lemenkov <lemenkov at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181012/f3124b5d/attachment.html>
More information about the coreboot-gerrit
mailing list