[coreboot-gerrit] Change in coreboot[master]: amd/stoneyridge: Fix SPI_CMD_TRIGGER coding style

Martin Roth (Code Review) gerrit at coreboot.org
Thu Oct 11 18:04:31 CEST 2018


Martin Roth has posted comments on this change. ( https://review.coreboot.org/29010 )

Change subject: amd/stoneyridge: Fix SPI_CMD_TRIGGER coding style
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/29010/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/29010/1//COMMIT_MSG@7
PS1, Line 7: md/stoneyridg
> I'll demur.  You're nearly the only person who does that.  Look through the git log and you'll see. […]
Personally, I go with 'soc/amd/stoneyridge', but amd/stoneyridge is enough to identify it, so I'm ok with it.



-- 
To view, visit https://review.coreboot.org/29010
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ed02494ba69237c38af61317e435d9575cefe1c
Gerrit-Change-Number: 29010
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Martin Roth <martinroth at google.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 16:04:31 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181011/c9e1785b/attachment.html>


More information about the coreboot-gerrit mailing list