[coreboot-gerrit] Change in coreboot[master]: amd/stoneyridge: Rearrange southbridge.h

Marshall Dawson (Code Review) gerrit at coreboot.org
Thu Oct 11 17:18:16 CEST 2018


Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/29013 )

Change subject: amd/stoneyridge: Rearrange southbridge.h
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/29013/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/29013/1//COMMIT_MSG@6
PS1, Line 6: 
           : amd/stoneyridge
> soc/amd/stoneyridge/include/soc:
I'll demur.  You're nearly the only person who does that.  Look through the git log and you'll see.

This is only a high level topic of a subject line and shouldn't be used to say what specific file is changed.  Due to the nature of a patch, it's already self-evident what file(s) are modified.



-- 
To view, visit https://review.coreboot.org/29013
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6ef21431db0e758eba0ea043b54c036ec6235fe
Gerrit-Change-Number: 29013
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 15:18:16 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181011/764737b1/attachment.html>


More information about the coreboot-gerrit mailing list