[coreboot-gerrit] Change in coreboot[master]: amd/stoneyridge: Rearrange southbridge.h

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29013 )

Change subject: amd/stoneyridge: Rearrange southbridge.h
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/29013/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/29013/1//COMMIT_MSG@6
PS1, Line 6: 
           : amd/stoneyridge
soc/amd/stoneyridge/include/soc:


https://review.coreboot.org/#/c/29013/1/src/soc/amd/stoneyridge/include/soc/southbridge.h
File src/soc/amd/stoneyridge/include/soc/southbridge.h:

https://review.coreboot.org/#/c/29013/1/src/soc/amd/stoneyridge/include/soc/southbridge.h@166
PS1, Line 166: #define   DEBUG_PORT_MASK		(BIT(16) | BIT(17) | (BIT(18))
> Macros with complex values should be enclosed in parentheses
I have seen this kind of problem before. It's encased in parenthesis, but Jenkins believe it's not.



-- 
To view, visit https://review.coreboot.org/29013
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6ef21431db0e758eba0ea043b54c036ec6235fe
Gerrit-Change-Number: 29013
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 01:56:28 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181011/f909d652/attachment.html>