[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nami: Add samsung_dimm_K4AAG165WB-MCRC SPD

Martin Roth (Code Review) gerrit at coreboot.org
Wed Oct 10 18:29:59 CEST 2018


Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/28974 )

Change subject: mb/google/poppy/variants/nami: Add samsung_dimm_K4AAG165WB-MCRC SPD
......................................................................

mb/google/poppy/variants/nami: Add samsung_dimm_K4AAG165WB-MCRC SPD

Add SPD file for sdp samsung_dimm_K4AAG165WB-MCRC (ram id: 9)

BUG=b:112679174
TEST=emerge-nami coreboot chromeos-bootimage

Change-Id: Iac1e3ca4b009cc9be94608cd342f535fa581a5eb
Signed-off-by: Chris Zhou <chris_zhou at compal.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/28974
Reviewed-by: Furquan Shaikh <furquan at google.com>
Reviewed-by: Martin Roth <martinroth at google.com>
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
---
A src/mainboard/google/poppy/spd/samsung_dimm_K4AAG165WB-MCRC.spd.hex
M src/mainboard/google/poppy/variants/nami/Makefile.inc
2 files changed, 33 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved
  Furquan Shaikh: Looks good to me, approved



diff --git a/src/mainboard/google/poppy/spd/samsung_dimm_K4AAG165WB-MCRC.spd.hex b/src/mainboard/google/poppy/spd/samsung_dimm_K4AAG165WB-MCRC.spd.hex
new file mode 100644
index 0000000..03547a9
--- /dev/null
+++ b/src/mainboard/google/poppy/spd/samsung_dimm_K4AAG165WB-MCRC.spd.hex
@@ -0,0 +1,32 @@
+23 11 0C 03 85 21 00 08 00 60 00 03 01 03 00 00
+00 00 07 0D F8 0F 00 00 6E 6E 6E 11 00 6E F0 0A
+20 08 00 05 00 A8 1B 28 28 00 78 00 14 3C 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 16 36 0B 35
+16 36 0B 35 00 00 16 36 0B 35 16 36 0B 35 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 9C B5 00 00 00 00 E7 D6 89 02
+0F 11 1F 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 66 CB
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+80 CE 00 00 00 00 00 00 00 4D 34 37 31 41 31 4B
+34 34 42 4D 30 2D 43 52 43 20 20 20 20 00 80 CE
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
diff --git a/src/mainboard/google/poppy/variants/nami/Makefile.inc b/src/mainboard/google/poppy/variants/nami/Makefile.inc
index b02b7d4..ae33c27 100644
--- a/src/mainboard/google/poppy/variants/nami/Makefile.inc
+++ b/src/mainboard/google/poppy/variants/nami/Makefile.inc
@@ -10,7 +10,7 @@
 SPD_SOURCES += hynix_dimm_H5AN8G6NAFR-UHC	# 0b0110
 SPD_SOURCES += samsung_dimm_K4A4G165WE-BCRC	# 0b0111
 SPD_SOURCES += samsung_dimm_K4A8G165WC-BCTD	# 0b1000
-SPD_SOURCES += empty_ddr4			# 0b1001
+SPD_SOURCES += samsung_dimm_K4AAG165WB-MCRC	# 0b1001
 SPD_SOURCES += empty_ddr4			# 0b1010
 SPD_SOURCES += empty_ddr4			# 0b1011
 SPD_SOURCES += empty_ddr4			# 0b1100

-- 
To view, visit https://review.coreboot.org/28974
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac1e3ca4b009cc9be94608cd342f535fa581a5eb
Gerrit-Change-Number: 28974
Gerrit-PatchSet: 2
Gerrit-Owner: Chris Zhou <chris_zhou at compal.corp-partner.google.com>
Gerrit-Reviewer: Chris Zhou <chris_zhou at compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Van Chen <van_chen at compal.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181010/f7770a14/attachment.html>


More information about the coreboot-gerrit mailing list