[coreboot-gerrit] Change in coreboot[master]: util/superiotool/smsc.c: Add SCH5504 register dump

[Felix Held (Code Review)]

Felix Held has submitted this change and it was merged. ( https://review.coreboot.org/28958 )

Change subject: util/superiotool/smsc.c: Add SCH5504 register dump
......................................................................

util/superiotool/smsc.c: Add SCH5504 register dump

There is no datasheet available for this SuperIO, but dumping all
possible registers on a Dell Optiplex GX520 resulted in data that was
similar to other supported chips. Data also matches what is set in the
BIOS, e.g. the parallel and serial ports' addresses.

Change-Id: I768e4b5ec1e73c53e1a2355e0a0657b7a5ccbb89
Signed-off-by: Angel Pons <th3fanbus at gmail.com>
Reviewed-on: https://review.coreboot.org/28958
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Felix Held <felix-coreboot at felixheld.de>
---
M util/superiotool/smsc.c
1 file changed, 26 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Felix Held: Looks good to me, approved



diff --git a/util/superiotool/smsc.c b/util/superiotool/smsc.c
index 820bc16..2fe940c 100644
--- a/util/superiotool/smsc.c
+++ b/util/superiotool/smsc.c
@@ -715,7 +715,32 @@
 			{0x30,0x60,0x61,0x62,0x63,0xf0,0xf1,0xf2,EOT},
 			{0x00,0x00,0x00,0x00,0x00,NANA,RSVD,0x04,EOT}},
 		{EOT}}},
-	{0x79, "SCH5504", {	/* From sensors-detect (no datasheet) */
+	{0x79, "SCH5504", {	/* No datasheet, reverse-engineered */
+		{NOLDN, NULL,	/* FIXME: Is this correct? */
+			{0x02,0x03,0x21,0x22,0x23,0x24,0x26,0x27,
+			 0x28,0x2a,0x2b,0x2c,0x2d,0x2e,0x2f,EOT},
+			{0x00,RSVD,MISC,0x00,0x00,0x04,MISC,0x00,
+			 RSVD,0x00,0x00,0x00,0x00,0x00,0x00,EOT}},
+		{0x0, "Floppy",
+			{0x30,0x60,0x61,0x70,0x74,0xf0,0xf1,0xf2,0xf4,
+			 0xf5,EOT},
+			{0x00,0x03,0xf0,0x06,0x02,0x0e,0x00,0xff,0x00,
+			 0x00,EOT}},
+		{0x3, "Parallel port",
+			{0x30,0x60,0x61,0x70,0x74,0xf0,0xf1,EOT},
+			{0x00,0x00,0x00,0x00,0x04,0x3c,0x00,EOT}},
+		{0x4, "COM1",
+			{0x30,0x60,0x61,0x70,0xf0,EOT},
+			{0x00,0x00,0x00,0x00,0x00,EOT}},
+		{0x5, "COM2",
+			{0x30,0x60,0x61,0x70,0xf0,0xf1,0xf2,EOT},
+			{0x00,0x00,0x00,0x00,0x00,0x02,0x03,EOT}},
+		{0x7, "Keyboard",
+			{0x30,0x70,0x72,0xf0,EOT},
+			{0x00,0x00,0x00,0x00,EOT}},
+		{0xa, "Runtime registers",	/* FIXME: Is this correct? */
+			{0x30,0x60,0x61,0x70,0xf0,0xf1,EOT},
+			{0x00,0x00,0x00,0x00,0x00,RSVD,EOT}},
 		{EOT}}},
 	{0x7a, "LPC47N217", {	/* Found in Toshiba Satellite A80-117. */
 		{NOLDN, NULL,

-- 
To view, visit https://review.coreboot.org/28958
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I768e4b5ec1e73c53e1a2355e0a0657b7a5ccbb89
Gerrit-Change-Number: 28958
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181010/02112d10/attachment.html>