<p>Felix Held <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/28958">View Change</a></p><div style="white-space:pre-wrap">Approvals:
build bot (Jenkins): Verified
Felix Held: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">util/superiotool/smsc.c: Add SCH5504 register dump<br><br>There is no datasheet available for this SuperIO, but dumping all<br>possible registers on a Dell Optiplex GX520 resulted in data that was<br>similar to other supported chips. Data also matches what is set in the<br>BIOS, e.g. the parallel and serial ports' addresses.<br><br>Change-Id: I768e4b5ec1e73c53e1a2355e0a0657b7a5ccbb89<br>Signed-off-by: Angel Pons <th3fanbus@gmail.com><br>Reviewed-on: https://review.coreboot.org/28958<br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>Reviewed-by: Felix Held <felix-coreboot@felixheld.de><br>---<br>M util/superiotool/smsc.c<br>1 file changed, 26 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/util/superiotool/smsc.c b/util/superiotool/smsc.c</span><br><span>index 820bc16..2fe940c 100644</span><br><span>--- a/util/superiotool/smsc.c</span><br><span>+++ b/util/superiotool/smsc.c</span><br><span>@@ -715,7 +715,32 @@</span><br><span> {0x30,0x60,0x61,0x62,0x63,0xf0,0xf1,0xf2,EOT},</span><br><span> {0x00,0x00,0x00,0x00,0x00,NANA,RSVD,0x04,EOT}},</span><br><span> {EOT}}},</span><br><span style="color: hsl(0, 100%, 40%);">- {0x79, "SCH5504", { /* From sensors-detect (no datasheet) */</span><br><span style="color: hsl(120, 100%, 40%);">+ {0x79, "SCH5504", { /* No datasheet, reverse-engineered */</span><br><span style="color: hsl(120, 100%, 40%);">+ {NOLDN, NULL, /* FIXME: Is this correct? */</span><br><span style="color: hsl(120, 100%, 40%);">+ {0x02,0x03,0x21,0x22,0x23,0x24,0x26,0x27,</span><br><span style="color: hsl(120, 100%, 40%);">+ 0x28,0x2a,0x2b,0x2c,0x2d,0x2e,0x2f,EOT},</span><br><span style="color: hsl(120, 100%, 40%);">+ {0x00,RSVD,MISC,0x00,0x00,0x04,MISC,0x00,</span><br><span style="color: hsl(120, 100%, 40%);">+ RSVD,0x00,0x00,0x00,0x00,0x00,0x00,EOT}},</span><br><span style="color: hsl(120, 100%, 40%);">+ {0x0, "Floppy",</span><br><span style="color: hsl(120, 100%, 40%);">+ {0x30,0x60,0x61,0x70,0x74,0xf0,0xf1,0xf2,0xf4,</span><br><span style="color: hsl(120, 100%, 40%);">+ 0xf5,EOT},</span><br><span style="color: hsl(120, 100%, 40%);">+ {0x00,0x03,0xf0,0x06,0x02,0x0e,0x00,0xff,0x00,</span><br><span style="color: hsl(120, 100%, 40%);">+ 0x00,EOT}},</span><br><span style="color: hsl(120, 100%, 40%);">+ {0x3, "Parallel port",</span><br><span style="color: hsl(120, 100%, 40%);">+ {0x30,0x60,0x61,0x70,0x74,0xf0,0xf1,EOT},</span><br><span style="color: hsl(120, 100%, 40%);">+ {0x00,0x00,0x00,0x00,0x04,0x3c,0x00,EOT}},</span><br><span style="color: hsl(120, 100%, 40%);">+ {0x4, "COM1",</span><br><span style="color: hsl(120, 100%, 40%);">+ {0x30,0x60,0x61,0x70,0xf0,EOT},</span><br><span style="color: hsl(120, 100%, 40%);">+ {0x00,0x00,0x00,0x00,0x00,EOT}},</span><br><span style="color: hsl(120, 100%, 40%);">+ {0x5, "COM2",</span><br><span style="color: hsl(120, 100%, 40%);">+ {0x30,0x60,0x61,0x70,0xf0,0xf1,0xf2,EOT},</span><br><span style="color: hsl(120, 100%, 40%);">+ {0x00,0x00,0x00,0x00,0x00,0x02,0x03,EOT}},</span><br><span style="color: hsl(120, 100%, 40%);">+ {0x7, "Keyboard",</span><br><span style="color: hsl(120, 100%, 40%);">+ {0x30,0x70,0x72,0xf0,EOT},</span><br><span style="color: hsl(120, 100%, 40%);">+ {0x00,0x00,0x00,0x00,EOT}},</span><br><span style="color: hsl(120, 100%, 40%);">+ {0xa, "Runtime registers", /* FIXME: Is this correct? */</span><br><span style="color: hsl(120, 100%, 40%);">+ {0x30,0x60,0x61,0x70,0xf0,0xf1,EOT},</span><br><span style="color: hsl(120, 100%, 40%);">+ {0x00,0x00,0x00,0x00,0x00,RSVD,EOT}},</span><br><span> {EOT}}},</span><br><span> {0x7a, "LPC47N217", { /* Found in Toshiba Satellite A80-117. */</span><br><span> {NOLDN, NULL,</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28958">change 28958</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28958"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I768e4b5ec1e73c53e1a2355e0a0657b7a5ccbb89 </div>
<div style="display:none"> Gerrit-Change-Number: 28958 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>