[coreboot-gerrit] Change in coreboot[master]: mb/google/fizz: Prepare sharing directory for variants

[David Wu (Code Review)]

David Wu has uploaded this change for review. ( https://review.coreboot.org/28959


Change subject: mb/google/fizz: Prepare sharing directory for variants
......................................................................

mb/google/fizz: Prepare sharing directory for variants

Clean up Kconfig file in order to support variants for fizz. Add
BOARD_GOOGLE_BASEBOARD_FIZZ that can be set by various fizz variants
to use the common baseboard configs.

BUG=b:117066935
BRANCH=Fizz
TEST=emerge-fizz coreboot

Change-Id: I9c89f1dc526a9d623e1ae4d4b52a923489b389d3
Signed-off-by: David Wu <david_wu at quanta.corp-partner.google.com>
---
M src/mainboard/google/fizz/Kconfig
M src/mainboard/google/fizz/Kconfig.name
2 files changed, 9 insertions(+), 7 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/28959/1

diff --git a/src/mainboard/google/fizz/Kconfig b/src/mainboard/google/fizz/Kconfig
index c6e43d8..7f4989b 100644
--- a/src/mainboard/google/fizz/Kconfig
+++ b/src/mainboard/google/fizz/Kconfig
@@ -1,7 +1,6 @@
-if BOARD_GOOGLE_FIZZ
 
-config BOARD_SPECIFIC_OPTIONS
-	def_bool y
+config BOARD_GOOGLE_BASEBOARD_FIZZ
+	def_bool n
 	select BOARD_ROMSIZE_KB_16384
 	select DRIVERS_I2C_GENERIC
 	select DRIVERS_SPI_ACPI
@@ -24,6 +23,8 @@
 	select RT8168_SET_LED_MODE
 	select SPD_READ_BY_WORD
 
+if BOARD_GOOGLE_BASEBOARD_FIZZ
+
 config VBOOT
 	select EC_GOOGLE_CHROMEEC_SWITCHES
 	select VBOOT_EC_EFS
@@ -37,7 +38,7 @@
 config GBB_HWID
 	string
 	depends on CHROMEOS
-	default "FIZZ TEST 5997"
+	default "FIZZ TEST 5997" if BOARD_GOOGLE_FIZZ
 
 config MAINBOARD_DIR
 	string
@@ -45,11 +46,11 @@
 
 config MAINBOARD_PART_NUMBER
 	string
-	default "Fizz"
+	default "Fizz" if BOARD_GOOGLE_FIZZ
 
 config MAINBOARD_FAMILY
 	string
-	default "Google_Fizz"
+	default "Google_Fizz" if BOARD_GOOGLE_FIZZ
 
 config MAX_CPUS
 	int
@@ -71,4 +72,4 @@
 	bool "Include blobs for audio."
 	select NHLT_RT5663
 
-endif
+endif # BOARD_GOOGLE_BASEBOARD_FIZZ
diff --git a/src/mainboard/google/fizz/Kconfig.name b/src/mainboard/google/fizz/Kconfig.name
index 12685d9..28c9700 100644
--- a/src/mainboard/google/fizz/Kconfig.name
+++ b/src/mainboard/google/fizz/Kconfig.name
@@ -1,2 +1,3 @@
 config BOARD_GOOGLE_FIZZ
 	bool "Fizz"
+	select BOARD_GOOGLE_BASEBOARD_FIZZ

-- 
To view, visit https://review.coreboot.org/28959
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c89f1dc526a9d623e1ae4d4b52a923489b389d3
Gerrit-Change-Number: 28959
Gerrit-PatchSet: 1
Gerrit-Owner: David Wu <david_wu at quanta.corp-partner.google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181008/dd620ad1/attachment.html>