<p>David Wu has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28959">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/fizz: Prepare sharing directory for variants<br><br>Clean up Kconfig file in order to support variants for fizz. Add<br>BOARD_GOOGLE_BASEBOARD_FIZZ that can be set by various fizz variants<br>to use the common baseboard configs.<br><br>BUG=b:117066935<br>BRANCH=Fizz<br>TEST=emerge-fizz coreboot<br><br>Change-Id: I9c89f1dc526a9d623e1ae4d4b52a923489b389d3<br>Signed-off-by: David Wu <david_wu@quanta.corp-partner.google.com><br>---<br>M src/mainboard/google/fizz/Kconfig<br>M src/mainboard/google/fizz/Kconfig.name<br>2 files changed, 9 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/28959/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/fizz/Kconfig b/src/mainboard/google/fizz/Kconfig</span><br><span>index c6e43d8..7f4989b 100644</span><br><span>--- a/src/mainboard/google/fizz/Kconfig</span><br><span>+++ b/src/mainboard/google/fizz/Kconfig</span><br><span>@@ -1,7 +1,6 @@</span><br><span style="color: hsl(0, 100%, 40%);">-if BOARD_GOOGLE_FIZZ</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-config BOARD_SPECIFIC_OPTIONS</span><br><span style="color: hsl(0, 100%, 40%);">-       def_bool y</span><br><span style="color: hsl(120, 100%, 40%);">+config BOARD_GOOGLE_BASEBOARD_FIZZ</span><br><span style="color: hsl(120, 100%, 40%);">+        def_bool n</span><br><span>   select BOARD_ROMSIZE_KB_16384</span><br><span>        select DRIVERS_I2C_GENERIC</span><br><span>   select DRIVERS_SPI_ACPI</span><br><span>@@ -24,6 +23,8 @@</span><br><span>  select RT8168_SET_LED_MODE</span><br><span>   select SPD_READ_BY_WORD</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+if BOARD_GOOGLE_BASEBOARD_FIZZ</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> config VBOOT</span><br><span>        select EC_GOOGLE_CHROMEEC_SWITCHES</span><br><span>   select VBOOT_EC_EFS</span><br><span>@@ -37,7 +38,7 @@</span><br><span> config GBB_HWID</span><br><span>   string</span><br><span>       depends on CHROMEOS</span><br><span style="color: hsl(0, 100%, 40%);">-     default "FIZZ TEST 5997"</span><br><span style="color: hsl(120, 100%, 40%);">+    default "FIZZ TEST 5997" if BOARD_GOOGLE_FIZZ</span><br><span> </span><br><span> config MAINBOARD_DIR</span><br><span>  string</span><br><span>@@ -45,11 +46,11 @@</span><br><span> </span><br><span> config MAINBOARD_PART_NUMBER</span><br><span>     string</span><br><span style="color: hsl(0, 100%, 40%);">-  default "Fizz"</span><br><span style="color: hsl(120, 100%, 40%);">+      default "Fizz" if BOARD_GOOGLE_FIZZ</span><br><span> </span><br><span> config MAINBOARD_FAMILY</span><br><span>         string</span><br><span style="color: hsl(0, 100%, 40%);">-  default "Google_Fizz"</span><br><span style="color: hsl(120, 100%, 40%);">+       default "Google_Fizz" if BOARD_GOOGLE_FIZZ</span><br><span> </span><br><span> config MAX_CPUS</span><br><span>  int</span><br><span>@@ -71,4 +72,4 @@</span><br><span>      bool "Include blobs for audio."</span><br><span>    select NHLT_RT5663</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-endif</span><br><span style="color: hsl(120, 100%, 40%);">+endif # BOARD_GOOGLE_BASEBOARD_FIZZ</span><br><span>diff --git a/src/mainboard/google/fizz/Kconfig.name b/src/mainboard/google/fizz/Kconfig.name</span><br><span>index 12685d9..28c9700 100644</span><br><span>--- a/src/mainboard/google/fizz/Kconfig.name</span><br><span>+++ b/src/mainboard/google/fizz/Kconfig.name</span><br><span>@@ -1,2 +1,3 @@</span><br><span> config BOARD_GOOGLE_FIZZ</span><br><span>  bool "Fizz"</span><br><span style="color: hsl(120, 100%, 40%);">+ select BOARD_GOOGLE_BASEBOARD_FIZZ</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28959">change 28959</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28959"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I9c89f1dc526a9d623e1ae4d4b52a923489b389d3 </div>
<div style="display:none"> Gerrit-Change-Number: 28959 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: David Wu <david_wu@quanta.corp-partner.google.com> </div>