[coreboot-gerrit] Change in coreboot[master]: src: Standardize PCI_DEV(0, 0x1f, 0) name

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/28956 )

Change subject: src: Standardize PCI_DEV(0, 0x1f, 0) name
......................................................................


Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/28956/5/src/southbridge/intel/bd82x6x/pch.h
File src/southbridge/intel/bd82x6x/pch.h:

https://review.coreboot.org/#/c/28956/5/src/southbridge/intel/bd82x6x/pch.h@133
PS5, Line 133: LPC_DEV		PCI_DEV(0, 0x1f, 0)
But now this doesn't match all of the other #defines for the platform.  We have the same issue on many other platforms.  I appreciate the effort, but I'm not positive it makes sense to try to standardize it across all platforms.

Are we going to standardize all of the others as well?



-- 
To view, visit https://review.coreboot.org/28956
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0be00e5e9c733bbeb863250bd51eea8d33f54300
Gerrit-Change-Number: 28956
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Martin Roth <martinroth at google.com>
Gerrit-Comment-Date: Sun, 07 Oct 2018 20:12:40 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181007/9e5b936f/attachment.html>