[coreboot-gerrit] Change in coreboot[master]: lenovo/x230: introduce variant FHD

[Alexander Couzens (Code Review)]

Alexander Couzens has uploaded this change for review. ( https://review.coreboot.org/28950


Change subject: lenovo/x230: introduce variant FHD
......................................................................

lenovo/x230: introduce variant FHD

The FHD (Full HD mod) is a modification to the x230
which uses the 2nd DP from the dock connector as internal
display connection. Further the old LVDS based display
can be replaced with an eDP.
When using the FHD, the LVDS connector should be disabled in
libgfxinit. Further modifing of the VBT allows
to make the brightness works out of the box.
The VBT has been modified by:
- removing LVDS port
- move 3rd DP (which is the 2nd DP from Dock)
  to the first connector in the list
- set the 3rd DP as internal connected

Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0
Signed-off-by: Alexander Couzens <lynxis at fe80.eu>
---
M src/mainboard/lenovo/x230/Kconfig
M src/mainboard/lenovo/x230/Kconfig.name
M src/mainboard/lenovo/x230/Makefile.inc
R src/mainboard/lenovo/x230/variants/x230/data.vbt
R src/mainboard/lenovo/x230/variants/x230/gma-mainboard.ads
A src/mainboard/lenovo/x230/variants/x230fhd/data.vbt
A src/mainboard/lenovo/x230/variants/x230fhd/gma-mainboard.ads
7 files changed, 44 insertions(+), 3 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/28950/1

diff --git a/src/mainboard/lenovo/x230/Kconfig b/src/mainboard/lenovo/x230/Kconfig
index 2725dcd..276754d 100644
--- a/src/mainboard/lenovo/x230/Kconfig
+++ b/src/mainboard/lenovo/x230/Kconfig
@@ -1,4 +1,4 @@
-if BOARD_LENOVO_X230
+if BOARD_LENOVO_X230 || BOARD_LENOVO_X230_FHD
 
 config BOARD_SPECIFIC_OPTIONS # dummy
 	def_bool y
@@ -63,4 +63,9 @@
 	hex
 	default 0x21fa
 
-endif # BOARD_LENOVO_X230
+config VARIANT_DIR
+	string
+	default "x230fhd" if BOARD_LENOVO_X230_FHD
+	default "x230" if BOARD_LENOVO_X230
+
+endif # BOARD_LENOVO_X230 || BOARD_LENOVO_X230_FHD
diff --git a/src/mainboard/lenovo/x230/Kconfig.name b/src/mainboard/lenovo/x230/Kconfig.name
index d207653..e8e1032 100644
--- a/src/mainboard/lenovo/x230/Kconfig.name
+++ b/src/mainboard/lenovo/x230/Kconfig.name
@@ -1,2 +1,5 @@
 config BOARD_LENOVO_X230
 	bool "ThinkPad X230"
+
+config BOARD_LENOVO_X230_FHD
+	bool "ThinkPad X230 Full HD mod"
diff --git a/src/mainboard/lenovo/x230/Makefile.inc b/src/mainboard/lenovo/x230/Makefile.inc
index 2dab950..b47278d 100644
--- a/src/mainboard/lenovo/x230/Makefile.inc
+++ b/src/mainboard/lenovo/x230/Makefile.inc
@@ -16,4 +16,4 @@
 smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
 romstage-y += gpio.c
 
-ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads
+ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += variants/$(VARIANT_DIR)/gma-mainboard.ads
diff --git a/src/mainboard/lenovo/x230/data.vbt b/src/mainboard/lenovo/x230/variants/x230/data.vbt
similarity index 100%
rename from src/mainboard/lenovo/x230/data.vbt
rename to src/mainboard/lenovo/x230/variants/x230/data.vbt
Binary files differ
diff --git a/src/mainboard/lenovo/x230/gma-mainboard.ads b/src/mainboard/lenovo/x230/variants/x230/gma-mainboard.ads
similarity index 100%
rename from src/mainboard/lenovo/x230/gma-mainboard.ads
rename to src/mainboard/lenovo/x230/variants/x230/gma-mainboard.ads
diff --git a/src/mainboard/lenovo/x230/variants/x230fhd/data.vbt b/src/mainboard/lenovo/x230/variants/x230fhd/data.vbt
new file mode 100644
index 0000000..1aaf542
--- /dev/null
+++ b/src/mainboard/lenovo/x230/variants/x230fhd/data.vbt
Binary files differ
diff --git a/src/mainboard/lenovo/x230/variants/x230fhd/gma-mainboard.ads b/src/mainboard/lenovo/x230/variants/x230fhd/gma-mainboard.ads
new file mode 100644
index 0000000..816a87d
--- /dev/null
+++ b/src/mainboard/lenovo/x230/variants/x230fhd/gma-mainboard.ads
@@ -0,0 +1,33 @@
+--
+-- This file is part of the coreboot project.
+--
+-- This program is free software; you can redistribute it and/or modify
+-- it under the terms of the GNU General Public License as published by
+-- the Free Software Foundation; either version 2 of the License, or
+-- (at your option) any later version.
+--
+-- This program is distributed in the hope that it will be useful,
+-- but WITHOUT ANY WARRANTY; without even the implied warranty of
+-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+-- GNU General Public License for more details.
+--
+
+with HW.GFX.GMA;
+with HW.GFX.GMA.Display_Probing;
+
+use HW.GFX.GMA;
+use HW.GFX.GMA.Display_Probing;
+
+private package GMA.Mainboard is
+
+   ports : constant Port_List :=
+     (DP1,
+      DP2,
+      DP3,
+      HDMI1,
+      HDMI2,
+      HDMI3,
+      Analog,
+      others => Disabled);
+
+end GMA.Mainboard;

-- 
To view, visit https://review.coreboot.org/28950
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0
Gerrit-Change-Number: 28950
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Couzens <lynxis at fe80.eu>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181006/511751f5/attachment.html>