<p>Alexander Couzens has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28950">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lenovo/x230: introduce variant FHD<br><br>The FHD (Full HD mod) is a modification to the x230<br>which uses the 2nd DP from the dock connector as internal<br>display connection. Further the old LVDS based display<br>can be replaced with an eDP.<br>When using the FHD, the LVDS connector should be disabled in<br>libgfxinit. Further modifing of the VBT allows<br>to make the brightness works out of the box.<br>The VBT has been modified by:<br>- removing LVDS port<br>- move 3rd DP (which is the 2nd DP from Dock)<br> to the first connector in the list<br>- set the 3rd DP as internal connected<br><br>Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0<br>Signed-off-by: Alexander Couzens <lynxis@fe80.eu><br>---<br>M src/mainboard/lenovo/x230/Kconfig<br>M src/mainboard/lenovo/x230/Kconfig.name<br>M src/mainboard/lenovo/x230/Makefile.inc<br>R src/mainboard/lenovo/x230/variants/x230/data.vbt<br>R src/mainboard/lenovo/x230/variants/x230/gma-mainboard.ads<br>A src/mainboard/lenovo/x230/variants/x230fhd/data.vbt<br>A src/mainboard/lenovo/x230/variants/x230fhd/gma-mainboard.ads<br>7 files changed, 44 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/28950/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/lenovo/x230/Kconfig b/src/mainboard/lenovo/x230/Kconfig</span><br><span>index 2725dcd..276754d 100644</span><br><span>--- a/src/mainboard/lenovo/x230/Kconfig</span><br><span>+++ b/src/mainboard/lenovo/x230/Kconfig</span><br><span>@@ -1,4 +1,4 @@</span><br><span style="color: hsl(0, 100%, 40%);">-if BOARD_LENOVO_X230</span><br><span style="color: hsl(120, 100%, 40%);">+if BOARD_LENOVO_X230 || BOARD_LENOVO_X230_FHD</span><br><span> </span><br><span> config BOARD_SPECIFIC_OPTIONS # dummy</span><br><span> def_bool y</span><br><span>@@ -63,4 +63,9 @@</span><br><span> hex</span><br><span> default 0x21fa</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-endif # BOARD_LENOVO_X230</span><br><span style="color: hsl(120, 100%, 40%);">+config VARIANT_DIR</span><br><span style="color: hsl(120, 100%, 40%);">+ string</span><br><span style="color: hsl(120, 100%, 40%);">+ default "x230fhd" if BOARD_LENOVO_X230_FHD</span><br><span style="color: hsl(120, 100%, 40%);">+ default "x230" if BOARD_LENOVO_X230</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+endif # BOARD_LENOVO_X230 || BOARD_LENOVO_X230_FHD</span><br><span>diff --git a/src/mainboard/lenovo/x230/Kconfig.name b/src/mainboard/lenovo/x230/Kconfig.name</span><br><span>index d207653..e8e1032 100644</span><br><span>--- a/src/mainboard/lenovo/x230/Kconfig.name</span><br><span>+++ b/src/mainboard/lenovo/x230/Kconfig.name</span><br><span>@@ -1,2 +1,5 @@</span><br><span> config BOARD_LENOVO_X230</span><br><span> bool "ThinkPad X230"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+config BOARD_LENOVO_X230_FHD</span><br><span style="color: hsl(120, 100%, 40%);">+ bool "ThinkPad X230 Full HD mod"</span><br><span>diff --git a/src/mainboard/lenovo/x230/Makefile.inc b/src/mainboard/lenovo/x230/Makefile.inc</span><br><span>index 2dab950..b47278d 100644</span><br><span>--- a/src/mainboard/lenovo/x230/Makefile.inc</span><br><span>+++ b/src/mainboard/lenovo/x230/Makefile.inc</span><br><span>@@ -16,4 +16,4 @@</span><br><span> smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c</span><br><span> romstage-y += gpio.c</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads</span><br><span style="color: hsl(120, 100%, 40%);">+ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += variants/$(VARIANT_DIR)/gma-mainboard.ads</span><br><span>diff --git a/src/mainboard/lenovo/x230/data.vbt b/src/mainboard/lenovo/x230/variants/x230/data.vbt</span><br><span>similarity index 100%</span><br><span>rename from src/mainboard/lenovo/x230/data.vbt</span><br><span>rename to src/mainboard/lenovo/x230/variants/x230/data.vbt</span><br><span>Binary files differ</span><br><span>diff --git a/src/mainboard/lenovo/x230/gma-mainboard.ads b/src/mainboard/lenovo/x230/variants/x230/gma-mainboard.ads</span><br><span>similarity index 100%</span><br><span>rename from src/mainboard/lenovo/x230/gma-mainboard.ads</span><br><span>rename to src/mainboard/lenovo/x230/variants/x230/gma-mainboard.ads</span><br><span>diff --git a/src/mainboard/lenovo/x230/variants/x230fhd/data.vbt b/src/mainboard/lenovo/x230/variants/x230fhd/data.vbt</span><br><span>new file mode 100644</span><br><span>index 0000000..1aaf542</span><br><span>--- /dev/null</span><br><span>+++ b/src/mainboard/lenovo/x230/variants/x230fhd/data.vbt</span><br><span>Binary files differ</span><br><span>diff --git a/src/mainboard/lenovo/x230/variants/x230fhd/gma-mainboard.ads b/src/mainboard/lenovo/x230/variants/x230fhd/gma-mainboard.ads</span><br><span>new file mode 100644</span><br><span>index 0000000..816a87d</span><br><span>--- /dev/null</span><br><span>+++ b/src/mainboard/lenovo/x230/variants/x230fhd/gma-mainboard.ads</span><br><span>@@ -0,0 +1,33 @@</span><br><span style="color: hsl(120, 100%, 40%);">+--</span><br><span style="color: hsl(120, 100%, 40%);">+-- This file is part of the coreboot project.</span><br><span style="color: hsl(120, 100%, 40%);">+--</span><br><span style="color: hsl(120, 100%, 40%);">+-- This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(120, 100%, 40%);">+-- it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(120, 100%, 40%);">+-- the Free Software Foundation; either version 2 of the License, or</span><br><span style="color: hsl(120, 100%, 40%);">+-- (at your option) any later version.</span><br><span style="color: hsl(120, 100%, 40%);">+--</span><br><span style="color: hsl(120, 100%, 40%);">+-- This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+-- but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(120, 100%, 40%);">+-- GNU General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+--</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+with HW.GFX.GMA;</span><br><span style="color: hsl(120, 100%, 40%);">+with HW.GFX.GMA.Display_Probing;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+use HW.GFX.GMA;</span><br><span style="color: hsl(120, 100%, 40%);">+use HW.GFX.GMA.Display_Probing;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+private package GMA.Mainboard is</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ ports : constant Port_List :=</span><br><span style="color: hsl(120, 100%, 40%);">+ (DP1,</span><br><span style="color: hsl(120, 100%, 40%);">+ DP2,</span><br><span style="color: hsl(120, 100%, 40%);">+ DP3,</span><br><span style="color: hsl(120, 100%, 40%);">+ HDMI1,</span><br><span style="color: hsl(120, 100%, 40%);">+ HDMI2,</span><br><span style="color: hsl(120, 100%, 40%);">+ HDMI3,</span><br><span style="color: hsl(120, 100%, 40%);">+ Analog,</span><br><span style="color: hsl(120, 100%, 40%);">+ others => Disabled);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+end GMA.Mainboard;</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28950">change 28950</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28950"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 </div>
<div style="display:none"> Gerrit-Change-Number: 28950 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Alexander Couzens <lynxis@fe80.eu> </div>