[coreboot-gerrit] Change in coreboot[master]: acpi: Reverse logic for setting PCIEXP_WAKE_DIS bit in PM1_EN_STS

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/28932 )

Change subject: acpi: Reverse logic for setting PCIEXP_WAKE_DIS bit in PM1_EN_STS
......................................................................


Patch Set 2:

(1 comment)

I don't think the change can fix the problem are facing now, I will suggest a force programming in mainboard smi, or just regular boot stage.

https://review.coreboot.org/#/c/28932/2/src/soc/intel/skylake/acpi.c
File src/soc/intel/skylake/acpi.c:

https://review.coreboot.org/#/c/28932/2/src/soc/intel/skylake/acpi.c@718
PS2, Line 718: if ((config->deep_sx_config & DSX_EN_WAKE_PIN) == 0)
if (!(config->deep_sx_config & DSX_EN_WAKE_PIN))



-- 
To view, visit https://review.coreboot.org/28932
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8b14ae2ae4d97e184906dec468b405134d590da
Gerrit-Change-Number: 28932
Gerrit-PatchSet: 2
Gerrit-Owner: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 05 Oct 2018 04:35:34 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181005/14d8f41e/attachment.html>