[coreboot-gerrit] Change in coreboot[master]: mb/google/kahlee: Don't set stapm parameters

[Martin Roth (Code Review)]

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/28925 )

Change subject: mb/google/kahlee: Don't set stapm parameters
......................................................................

mb/google/kahlee: Don't set stapm parameters

Setting the stapm parameters is causing S3 resume failures and
performance issues.  Removing these settings until more testing is
done and the issues are solved.

BUG=b:117252463, b:116870267
TEST=boot grunt

Change-Id: I2299ab81fcc2af0529bfac3be562b05116c64a49
Signed-off-by: Martin Roth <martinroth at google.com>
Reviewed-on: https://review.coreboot.org/28925
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Raul Rangel <rrangel at chromium.org>
Reviewed-by: Richard Spiegel <richard.spiegel at silverbackltd.com>
---
M src/mainboard/google/kahlee/variants/careena/devicetree.cb
M src/mainboard/google/kahlee/variants/grunt/devicetree.cb
2 files changed, 10 insertions(+), 6 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Richard Spiegel: Looks good to me, approved
  Raul Rangel: Looks good to me, approved



diff --git a/src/mainboard/google/kahlee/variants/careena/devicetree.cb b/src/mainboard/google/kahlee/variants/careena/devicetree.cb
index eb2acb9..08d4d4d 100644
--- a/src/mainboard/google/kahlee/variants/careena/devicetree.cb
+++ b/src/mainboard/google/kahlee/variants/careena/devicetree.cb
@@ -20,9 +20,11 @@
 	register "dram_clear_on_reset" = "DRAM_CONTENTS_KEEP"
 	register "uma_mode" = "UMAMODE_SPECIFIED_SIZE"
 	register "uma_size" = "32 * MiB"
-	register "stapm_percent" = "68"
-	register "stapm_time" = "2500"
-	register "stapm_power" = "7800"
+
+	# Don't set STAPM values for now
+	# register "stapm_percent" = "68"
+	# register "stapm_time" = "2500"
+	# register "stapm_power" = "7800"
 
 	# Enable I2C0 for audio, USB3 hub at 400kHz
 	register "i2c[0]" = "{
diff --git a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb
index 228ead2..128de7d 100644
--- a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb
+++ b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb
@@ -20,9 +20,11 @@
 	register "dram_clear_on_reset" = "DRAM_CONTENTS_KEEP"
 	register "uma_mode" = "UMAMODE_SPECIFIED_SIZE"
 	register "uma_size" = "32 * MiB"
-	register "stapm_percent" = "80"
-	register "stapm_time" = "2500"
-	register "stapm_power" = "7800"
+
+	# For now, don't set STAPM values
+	# register "stapm_percent" = "80"
+	# register "stapm_time" = "2500"
+	# register "stapm_power" = "7800"
 
 	# Enable I2C0 for audio, USB3 hub at 400kHz
 	register "i2c[0]" = "{

-- 
To view, visit https://review.coreboot.org/28925
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2299ab81fcc2af0529bfac3be562b05116c64a49
Gerrit-Change-Number: 28925
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181004/1b487f45/attachment.html>