<p>Martin Roth <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/28925">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  build bot (Jenkins): Verified
  Richard Spiegel: Looks good to me, approved
  Raul Rangel: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/kahlee: Don't set stapm parameters<br><br>Setting the stapm parameters is causing S3 resume failures and<br>performance issues.  Removing these settings until more testing is<br>done and the issues are solved.<br><br>BUG=b:117252463, b:116870267<br>TEST=boot grunt<br><br>Change-Id: I2299ab81fcc2af0529bfac3be562b05116c64a49<br>Signed-off-by: Martin Roth <martinroth@google.com><br>Reviewed-on: https://review.coreboot.org/28925<br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>Reviewed-by: Raul Rangel <rrangel@chromium.org><br>Reviewed-by: Richard Spiegel <richard.spiegel@silverbackltd.com><br>---<br>M src/mainboard/google/kahlee/variants/careena/devicetree.cb<br>M src/mainboard/google/kahlee/variants/grunt/devicetree.cb<br>2 files changed, 10 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/kahlee/variants/careena/devicetree.cb b/src/mainboard/google/kahlee/variants/careena/devicetree.cb</span><br><span>index eb2acb9..08d4d4d 100644</span><br><span>--- a/src/mainboard/google/kahlee/variants/careena/devicetree.cb</span><br><span>+++ b/src/mainboard/google/kahlee/variants/careena/devicetree.cb</span><br><span>@@ -20,9 +20,11 @@</span><br><span>         register "dram_clear_on_reset" = "DRAM_CONTENTS_KEEP"</span><br><span>    register "uma_mode" = "UMAMODE_SPECIFIED_SIZE"</span><br><span>   register "uma_size" = "32 * MiB"</span><br><span style="color: hsl(0, 100%, 40%);">-    register "stapm_percent" = "68"</span><br><span style="color: hsl(0, 100%, 40%);">-     register "stapm_time" = "2500"</span><br><span style="color: hsl(0, 100%, 40%);">-      register "stapm_power" = "7800"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ # Don't set STAPM values for now</span><br><span style="color: hsl(120, 100%, 40%);">+  # register "stapm_percent" = "68"</span><br><span style="color: hsl(120, 100%, 40%);">+ # register "stapm_time" = "2500"</span><br><span style="color: hsl(120, 100%, 40%);">+  # register "stapm_power" = "7800"</span><br><span> </span><br><span>    # Enable I2C0 for audio, USB3 hub at 400kHz</span><br><span>  register "i2c[0]" = "{</span><br><span>diff --git a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb</span><br><span>index 228ead2..128de7d 100644</span><br><span>--- a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb</span><br><span>+++ b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb</span><br><span>@@ -20,9 +20,11 @@</span><br><span>      register "dram_clear_on_reset" = "DRAM_CONTENTS_KEEP"</span><br><span>    register "uma_mode" = "UMAMODE_SPECIFIED_SIZE"</span><br><span>   register "uma_size" = "32 * MiB"</span><br><span style="color: hsl(0, 100%, 40%);">-    register "stapm_percent" = "80"</span><br><span style="color: hsl(0, 100%, 40%);">-     register "stapm_time" = "2500"</span><br><span style="color: hsl(0, 100%, 40%);">-      register "stapm_power" = "7800"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ # For now, don't set STAPM values</span><br><span style="color: hsl(120, 100%, 40%);">+ # register "stapm_percent" = "80"</span><br><span style="color: hsl(120, 100%, 40%);">+ # register "stapm_time" = "2500"</span><br><span style="color: hsl(120, 100%, 40%);">+  # register "stapm_power" = "7800"</span><br><span> </span><br><span>    # Enable I2C0 for audio, USB3 hub at 400kHz</span><br><span>  register "i2c[0]" = "{</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28925">change 28925</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28925"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I2299ab81fcc2af0529bfac3be562b05116c64a49 </div>
<div style="display:none"> Gerrit-Change-Number: 28925 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Daniel Kurtz <djkurtz@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>