[coreboot-gerrit] Change in coreboot[master]: UPSTREAM: mb/google/octopus: Bobba Touchpad I2C CLK (406.3KHz)over sp...

[Pan Sheng-Liang (Code Review)]

Hello Sheng-Liang Pan,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/28907

to review the following change.


Change subject: UPSTREAM: mb/google/octopus: Bobba Touchpad I2C CLK (406.3KHz)over spec(400KHz)
......................................................................

UPSTREAM: mb/google/octopus: Bobba Touchpad I2C CLK (406.3KHz)over
spec(400KHz)

Need to tune I2C bus 6 clock frequency under the 400KHz

Bug=b:117126484
TEST=flash coreboot to the DUT and measure I2C bus 6 clock
frequency whether arrive to 396.8KHz

Change-Id: Icb9592c688b864a21efd4963a4463845dfaa06fb
Signed-off-by: Pan Sheng-Liang <sheng-liang.pan at quanta.corp-partner.google.com>
---
M src/mainboard/google/octopus/variants/bobba/overridetree.cb
1 file changed, 40 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/28907/1

diff --git a/src/mainboard/google/octopus/variants/bobba/overridetree.cb b/src/mainboard/google/octopus/variants/bobba/overridetree.cb
index acb1d50..600aaed 100644
--- a/src/mainboard/google/octopus/variants/bobba/overridetree.cb
+++ b/src/mainboard/google/octopus/variants/bobba/overridetree.cb
@@ -1,5 +1,45 @@
 chip soc/intel/apollolake
 
+	# Intel Common SoC Config
+	#+-------------------+---------------------------+
+	#| Field             |  Value                    |
+	#+-------------------+---------------------------+
+	#| GSPI0             | cr50 TPM. Early init is   |
+	#|                   | required to set up a BAR  |
+	#|                   | for TPM communication     |
+	#|                   | before memory is up       |
+	#| I2C5              | Audio                     |
+	#| I2C6              | Trackpad                  |
+	#| I2C7              | Touchscreen               |
+	#+-------------------+---------------------------+
+	register "common_soc_config" = "{
+		.gspi[0] = {
+			.speed_mhz = 1,
+			.early_init = 1,
+		},
+		.i2c[0] = {
+			.speed = I2C_SPEED_FAST,
+			.rise_time_ns = 152,
+			.fall_time_ns = 30,
+		},
+		.i2c[5] = {
+			.speed = I2C_SPEED_FAST,
+			.rise_time_ns = 104,
+			.fall_time_ns = 52,
+		},
+		.i2c[6] = {
+			.speed = I2C_SPEED_FAST,
+			.rise_time_ns = 66,
+			.fall_time_ns = 90,
+			.data_hold_time_ns = 350,
+		},
+		.i2c[7] = {
+			.speed = I2C_SPEED_FAST,
+			.rise_time_ns = 76,
+			.fall_time_ns = 164,
+		},
+	}"
+
 	device domain 0 on
 		device pci 16.0 on
 			chip drivers/i2c/hid

-- 
To view, visit https://review.coreboot.org/28907
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb9592c688b864a21efd4963a4463845dfaa06fb
Gerrit-Change-Number: 28907
Gerrit-PatchSet: 1
Gerrit-Owner: Pan Sheng-Liang <sl.pan.quantw at gmail.com>
Gerrit-Reviewer: Sheng-Liang Pan <sheng-liang.pan at quanta.corp-partner.google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181004/6e377318/attachment-0001.html>