<p>Pan Sheng-Liang would like Sheng-Liang Pan to <strong>review</strong> this change.</p><p><a href="https://review.coreboot.org/28907">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">UPSTREAM: mb/google/octopus: Bobba Touchpad I2C CLK (406.3KHz)over<br>spec(400KHz)<br><br>Need to tune I2C bus 6 clock frequency under the 400KHz<br><br>Bug=b:117126484<br>TEST=flash coreboot to the DUT and measure I2C bus 6 clock<br>frequency whether arrive to 396.8KHz<br><br>Change-Id: Icb9592c688b864a21efd4963a4463845dfaa06fb<br>Signed-off-by: Pan Sheng-Liang <sheng-liang.pan@quanta.corp-partner.google.com><br>---<br>M src/mainboard/google/octopus/variants/bobba/overridetree.cb<br>1 file changed, 40 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/28907/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/octopus/variants/bobba/overridetree.cb b/src/mainboard/google/octopus/variants/bobba/overridetree.cb</span><br><span>index acb1d50..600aaed 100644</span><br><span>--- a/src/mainboard/google/octopus/variants/bobba/overridetree.cb</span><br><span>+++ b/src/mainboard/google/octopus/variants/bobba/overridetree.cb</span><br><span>@@ -1,5 +1,45 @@</span><br><span> chip soc/intel/apollolake</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ # Intel Common SoC Config</span><br><span style="color: hsl(120, 100%, 40%);">+ #+-------------------+---------------------------+</span><br><span style="color: hsl(120, 100%, 40%);">+ #| Field | Value |</span><br><span style="color: hsl(120, 100%, 40%);">+ #+-------------------+---------------------------+</span><br><span style="color: hsl(120, 100%, 40%);">+ #| GSPI0 | cr50 TPM. Early init is |</span><br><span style="color: hsl(120, 100%, 40%);">+ #| | required to set up a BAR |</span><br><span style="color: hsl(120, 100%, 40%);">+ #| | for TPM communication |</span><br><span style="color: hsl(120, 100%, 40%);">+ #| | before memory is up |</span><br><span style="color: hsl(120, 100%, 40%);">+ #| I2C5 | Audio |</span><br><span style="color: hsl(120, 100%, 40%);">+ #| I2C6 | Trackpad |</span><br><span style="color: hsl(120, 100%, 40%);">+ #| I2C7 | Touchscreen |</span><br><span style="color: hsl(120, 100%, 40%);">+ #+-------------------+---------------------------+</span><br><span style="color: hsl(120, 100%, 40%);">+ register "common_soc_config" = "{</span><br><span style="color: hsl(120, 100%, 40%);">+ .gspi[0] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ .speed_mhz = 1,</span><br><span style="color: hsl(120, 100%, 40%);">+ .early_init = 1,</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ .i2c[0] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ .speed = I2C_SPEED_FAST,</span><br><span style="color: hsl(120, 100%, 40%);">+ .rise_time_ns = 152,</span><br><span style="color: hsl(120, 100%, 40%);">+ .fall_time_ns = 30,</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ .i2c[5] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ .speed = I2C_SPEED_FAST,</span><br><span style="color: hsl(120, 100%, 40%);">+ .rise_time_ns = 104,</span><br><span style="color: hsl(120, 100%, 40%);">+ .fall_time_ns = 52,</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ .i2c[6] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ .speed = I2C_SPEED_FAST,</span><br><span style="color: hsl(120, 100%, 40%);">+ .rise_time_ns = 66,</span><br><span style="color: hsl(120, 100%, 40%);">+ .fall_time_ns = 90,</span><br><span style="color: hsl(120, 100%, 40%);">+ .data_hold_time_ns = 350,</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ .i2c[7] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ .speed = I2C_SPEED_FAST,</span><br><span style="color: hsl(120, 100%, 40%);">+ .rise_time_ns = 76,</span><br><span style="color: hsl(120, 100%, 40%);">+ .fall_time_ns = 164,</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ }"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> device domain 0 on</span><br><span> device pci 16.0 on</span><br><span> chip drivers/i2c/hid</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28907">change 28907</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28907"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Icb9592c688b864a21efd4963a4463845dfaa06fb </div>
<div style="display:none"> Gerrit-Change-Number: 28907 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pan Sheng-Liang <sl.pan.quantw@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> </div>