[coreboot-gerrit] Change in coreboot[master]: mb/google/kahlee: Update I2c values for older careena boards

Martin Roth (Code Review) gerrit at coreboot.org
Wed Oct 3 20:57:45 CEST 2018


Hello build bot (Jenkins), Kevin Chiu, Raul Rangel, Daniel Kurtz, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/28905

to look at the new patch set (#2).

Change subject: mb/google/kahlee: Update I2c values for older careena boards
......................................................................

mb/google/kahlee: Update I2c values for older careena boards

The I2C values are typically set in devicetree.cb, but there's an issue
where the values need to change between board versions.  This allows
the mainboard to update the settings at runtime.

BUG=B:110984023
TEST=I2C is set correctly on each version.

Change-Id: I1d17c502244c43e9a8f89471f7b04b3467a6e486
Signed-off-by: Martin Roth <martinroth at chromium.org>
---
M src/mainboard/google/kahlee/variants/careena/Makefile.inc
A src/mainboard/google/kahlee/variants/careena/i2c.c
2 files changed, 52 insertions(+), 0 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/28905/2
-- 
To view, visit https://review.coreboot.org/28905
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1d17c502244c43e9a8f89471f7b04b3467a6e486
Gerrit-Change-Number: 28905
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu at quantatw.com>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181003/d05ec22a/attachment.html>


More information about the coreboot-gerrit mailing list