[coreboot-gerrit] Change in coreboot[master]: mb/google/kahlee: Update I2c values for older careena boards

[Raul Rangel (Code Review)]

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/28905 )

Change subject: mb/google/kahlee: Update I2c values for older careena boards
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/28905/1/src/mainboard/google/kahlee/variants/careena/i2c.c
File src/mainboard/google/kahlee/variants/careena/i2c.c:

https://review.coreboot.org/#/c/28905/1/src/mainboard/google/kahlee/variants/careena/i2c.c@42
PS1, Line 42:  
Ah, I see you are just replacing the whole struct instead of updating each value.



-- 
To view, visit https://review.coreboot.org/28905
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d17c502244c43e9a8f89471f7b04b3467a6e486
Gerrit-Change-Number: 28905
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu at quantatw.com>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 03 Oct 2018 18:45:48 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181003/5eb8e07b/attachment.html>