[coreboot-gerrit] Change in coreboot[master]: src/lib/edid.c: Replace #if 1 with something useful

Angel Pons (Code Review) gerrit at coreboot.org
Tue Oct 2 19:51:22 CEST 2018


Hello Jonathan Neuschäfer, build bot (Jenkins), Nico Huber, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/28872

to look at the new patch set (#2).

Change subject: src/lib/edid.c: Replace #if 1 with something useful
......................................................................

src/lib/edid.c: Replace #if 1 with something useful

Since `#if 1` is rather useless, and the code inside it is just several
`printk(BIOS_SPEW)`, using `IS_ENABLED(CONFIG_DEFAULT_CONSOLE_LOGLEVEL_8)`
instead seems more reasonable.

Change-Id: I93dcab3db958480626fea6d99ab5289ebff04e8f
Signed-off-by: Angel Pons <th3fanbus at gmail.com>
---
M src/lib/edid.c
1 file changed, 7 insertions(+), 6 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/28872/2
-- 
To view, visit https://review.coreboot.org/28872
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I93dcab3db958480626fea6d99ab5289ebff04e8f
Gerrit-Change-Number: 28872
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181002/0392b4e4/attachment.html>


More information about the coreboot-gerrit mailing list