[coreboot-gerrit] Change in coreboot[master]: src/lib/edid.c: Replace #if 1 with something useful

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28872 )

Change subject: src/lib/edid.c: Replace #if 1 with something useful
......................................................................


Patch Set 1:

(1 comment)

A bit too much bikeshedding (this crappy EDID code usually doesn't
deserve my attention) but ignoring what dark corner this is about:
we can do better ;)

https://review.coreboot.org/#/c/28872/1/src/lib/edid.c
File src/lib/edid.c:

https://review.coreboot.org/#/c/28872/1/src/lib/edid.c@207
PS1, Line 207: #if CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8
`> 8` means BIOS_NEVER. Probably not the intention, writing
`> BIOS_SPEW` would have made that obvious :-P

Also I see no real benefit of an #if at all. It's ramstage
code (we don't have to save every single byte in flash) and it
doesn't have side effects (beside the potential log output).
And, anyway, you could write it in C and it would still be
dropped from the binary in case:

    if (IS_ENABLED(CONFIG_DEFAULT_CONSOLE_LOGLEVEL_8)) {



-- 
To view, visit https://review.coreboot.org/28872
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93dcab3db958480626fea6d99ab5289ebff04e8f
Gerrit-Change-Number: 28872
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 02 Oct 2018 11:12:39 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181002/84b80c07/attachment.html>