[coreboot-gerrit] Change in coreboot[master]: amd/stoneyridge: Remove SATA D0 on suspend
Marshall Dawson (Code Review)
gerrit at coreboot.org
Mon Oct 1 23:18:10 CEST 2018
Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/28863
Change subject: amd/stoneyridge: Remove SATA D0 on suspend
......................................................................
amd/stoneyridge: Remove SATA D0 on suspend
Remove the step of setting the SATA controller to S0 as the system is
entering S3. This had been duplicated from AMD's FchCarrizo.asl file,
but upon closer inspection, the conditions for this step to run cannot
be met. This does not affect Grunt's behavior, as the SATA controller
is disabled.
TEST=Suspend and resume Grunt
BUG=b:77602074
Change-Id: Ib269a5363d03c7048abd0c8a9a28df92a773790c
Signed-off-by: Marshall Dawson <marshalldawson3rd at gmail.com>
---
M src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/28863/1
diff --git a/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl b/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl
index 77c288b..7ac9139 100644
--- a/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl
+++ b/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl
@@ -592,10 +592,6 @@
if(LNotEqual(U2TD, 0x03)) {
FDDC(18, 3)
}
-
- if(LNotEqual(SATD, 0x00)) {
- FDDC(15, 0) /* wake SATA before sleep */
- }
}
Method(FWAK,0, Serialized) /* FCH _WAK */
--
To view, visit https://review.coreboot.org/28863
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib269a5363d03c7048abd0c8a9a28df92a773790c
Gerrit-Change-Number: 28863
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181001/45329df4/attachment-0001.html>
More information about the coreboot-gerrit
mailing list