<p>Marshall Dawson has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28863">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">amd/stoneyridge: Remove SATA D0 on suspend<br><br>Remove the step of setting the SATA controller to S0 as the system is<br>entering S3.  This had been duplicated from AMD's FchCarrizo.asl file,<br>but upon closer inspection, the conditions for this step to run cannot<br>be met.  This does not affect Grunt's behavior, as the SATA controller<br>is disabled.<br><br>TEST=Suspend and resume Grunt<br>BUG=b:77602074<br><br>Change-Id: Ib269a5363d03c7048abd0c8a9a28df92a773790c<br>Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com><br>---<br>M src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl<br>1 file changed, 0 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/28863/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl b/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl</span><br><span>index 77c288b..7ac9139 100644</span><br><span>--- a/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl</span><br><span>+++ b/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl</span><br><span>@@ -592,10 +592,6 @@</span><br><span>     if(LNotEqual(U2TD, 0x03)) {</span><br><span>          FDDC(18, 3)</span><br><span>  }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-       if(LNotEqual(SATD, 0x00)) {</span><br><span style="color: hsl(0, 100%, 40%);">-             FDDC(15, 0) /* wake SATA before sleep */</span><br><span style="color: hsl(0, 100%, 40%);">-        }</span><br><span> }</span><br><span> </span><br><span> Method(FWAK,0, Serialized)  /* FCH _WAK */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28863">change 28863</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28863"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ib269a5363d03c7048abd0c8a9a28df92a773790c </div>
<div style="display:none"> Gerrit-Change-Number: 28863 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Marshall Dawson <marshalldawson3rd@gmail.com> </div>