[coreboot-gerrit] Change in ...coreboot[master]: qcs405: Add GPIO API

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29955 )

Change subject: qcs405: Add GPIO API
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/29955/2/src/soc/qualcomm/qcs405/include/soc/gpio.h 
File src/soc/qualcomm/qcs405/include/soc/gpio.h:

https://review.coreboot.org/#/c/29955/2/src/soc/qualcomm/qcs405/include/soc/gpio.h@90 
PS2, Line 90: #define PIN(index, tlmm, func1, func2, func3, func4, func5, func6, func7) \
Macros with complex values should be enclosed in parentheses



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29955
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85ce9007c545b44371c4704a0456774d0eff12a8
Gerrit-Change-Number: 29955
Gerrit-PatchSet: 2
Gerrit-Owner: nsekar at codeaurora.org
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: nsekar at codeaurora.org
Gerrit-Comment-Date: Fri, 30 Nov 2018 14:06:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181130/4a098ed9/attachment.html>