[coreboot-gerrit] Change in ...coreboot[master]: nb/intel/gm45: Make fetching the blc_pwm freq its own function

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29924 )

Change subject: nb/intel/gm45: Make fetching the blc_pwm freq its own function
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/29924/1/src/northbridge/intel/gm45/gma.c 
File src/northbridge/intel/gm45/gma.c:

https://review.coreboot.org/#/c/29924/1/src/northbridge/intel/gm45/gma.c@673 
PS1, Line 673:  = -1
Initialization is unnecessary as you check `> 0`.


https://review.coreboot.org/#/c/29924/1/src/northbridge/intel/gm45/gma.c@684 
PS1, Line 684: 		if (!strcmp(blc_pwm[i].ascii_string, edid_ascii_string)) {
Please mention this tiny functional change in the commit message.


https://review.coreboot.org/#/c/29924/1/src/northbridge/intel/gm45/gma.c@746 
PS1, Line 746: 	if (pwm_freq < 0)
eeeek, it's unsigned



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29924
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ad364f84f3658be98ce7ad3a6f0f0fe3247fc41
Gerrit-Change-Number: 29924
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Thu, 29 Nov 2018 13:04:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181129/357be28e/attachment.html>