<p><a href="https://review.coreboot.org/c/coreboot/+/29924">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29924/1/src/northbridge/intel/gm45/gma.c">File src/northbridge/intel/gm45/gma.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29924/1/src/northbridge/intel/gm45/gma.c@673">Patch Set #1, Line 673:</a> <code style="font-family:monospace,monospace"> = -1</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Initialization is unnecessary as you check `> 0`.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29924/1/src/northbridge/intel/gm45/gma.c@684">Patch Set #1, Line 684:</a> <code style="font-family:monospace,monospace">          if (!strcmp(blc_pwm[i].ascii_string, edid_ascii_string)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Please mention this tiny functional change in the commit message.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29924/1/src/northbridge/intel/gm45/gma.c@746">Patch Set #1, Line 746:</a> <code style="font-family:monospace,monospace">      if (pwm_freq < 0)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">eeeek, it's unsigned</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/29924">change 29924</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/29924"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9ad364f84f3658be98ce7ad3a6f0f0fe3247fc41 </div>
<div style="display:none"> Gerrit-Change-Number: 29924 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 29 Nov 2018 13:04:34 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>