[coreboot-gerrit] Change in ...coreboot[master]: src/drivers/spi: Remove not used variable

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29917


Change subject: src/drivers/spi: Remove not used variable
......................................................................

src/drivers/spi: Remove not used variable

Change-Id: Ibdfbf1031130ff861c4313d1271d6ccb68bf8837
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
M Makefile.inc
M src/drivers/spi/sst.c
2 files changed, 2 insertions(+), 3 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/29917/1

diff --git a/Makefile.inc b/Makefile.inc
index aaae7bc..df3e227 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -395,7 +395,7 @@
 CFLAGS_common += -Wno-packed-not-aligned
 CFLAGS_common += -fconserve-stack
 # cf. commit f69a99db (coreboot: x86: enable gc-sections)
-CFLAGS_common += -Wno-unused-but-set-variable
+CFLAGS_common += -Wall
 endif
 endif
 
diff --git a/src/drivers/spi/sst.c b/src/drivers/spi/sst.c
index 559969a..7a0428f 100644
--- a/src/drivers/spi/sst.c
+++ b/src/drivers/spi/sst.c
@@ -172,7 +172,7 @@
 static int sst_write_256(const struct spi_flash *flash, u32 offset, size_t len,
 			const void *buf)
 {
-	size_t actual, chunk_len, cmd_len;
+	size_t actual, chunk_len;
 	unsigned long byte_addr;
 	unsigned long page_size;
 	int ret = 0;
@@ -193,7 +193,6 @@
 	if (ret)
 		goto done;
 
-	cmd_len = 4;
 	cmd[0] = CMD_SST_AAI_WP;
 	cmd[1] = offset >> 16;
 	cmd[2] = offset >> 8;

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29917
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibdfbf1031130ff861c4313d1271d6ccb68bf8837
Gerrit-Change-Number: 29917
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181129/3b7b2aa5/attachment.html>