<p>HAOUAS Elyes has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/29917">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">src/drivers/spi: Remove not used variable<br><br>Change-Id: Ibdfbf1031130ff861c4313d1271d6ccb68bf8837<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M Makefile.inc<br>M src/drivers/spi/sst.c<br>2 files changed, 2 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/29917/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Makefile.inc b/Makefile.inc</span><br><span>index aaae7bc..df3e227 100644</span><br><span>--- a/Makefile.inc</span><br><span>+++ b/Makefile.inc</span><br><span>@@ -395,7 +395,7 @@</span><br><span> CFLAGS_common += -Wno-packed-not-aligned</span><br><span> CFLAGS_common += -fconserve-stack</span><br><span> # cf. commit f69a99db (coreboot: x86: enable gc-sections)</span><br><span style="color: hsl(0, 100%, 40%);">-CFLAGS_common += -Wno-unused-but-set-variable</span><br><span style="color: hsl(120, 100%, 40%);">+CFLAGS_common += -Wall</span><br><span> endif</span><br><span> endif</span><br><span> </span><br><span>diff --git a/src/drivers/spi/sst.c b/src/drivers/spi/sst.c</span><br><span>index 559969a..7a0428f 100644</span><br><span>--- a/src/drivers/spi/sst.c</span><br><span>+++ b/src/drivers/spi/sst.c</span><br><span>@@ -172,7 +172,7 @@</span><br><span> static int sst_write_256(const struct spi_flash *flash, u32 offset, size_t len,</span><br><span>                       const void *buf)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-   size_t actual, chunk_len, cmd_len;</span><br><span style="color: hsl(120, 100%, 40%);">+    size_t actual, chunk_len;</span><br><span>    unsigned long byte_addr;</span><br><span>     unsigned long page_size;</span><br><span>     int ret = 0;</span><br><span>@@ -193,7 +193,6 @@</span><br><span>   if (ret)</span><br><span>             goto done;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  cmd_len = 4;</span><br><span>         cmd[0] = CMD_SST_AAI_WP;</span><br><span>     cmd[1] = offset >> 16;</span><br><span>         cmd[2] = offset >> 8;</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/29917">change 29917</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/29917"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ibdfbf1031130ff861c4313d1271d6ccb68bf8837 </div>
<div style="display:none"> Gerrit-Change-Number: 29917 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>