[coreboot-gerrit] Change in ...coreboot[master]: mb/poppy/variant/nami: Move FPMCU_INT_L gpios to B group

Ren Kuo (Code Review) gerrit at coreboot.org
Thu Nov 29 03:50:58 CET 2018


Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29872 )

Change subject: mb/poppy/variant/nami: Move FPMCU_INT_L gpios to B group
......................................................................


Patch Set 2:

Hi Shelley and Furquan

I tried PAD_CFG_GPI_APIC_INVERT, the FP function can work. (lock/un-lock OK)
If I set as  PAD_CFG_GPI_APIC, the fp function can Not work.

Our test result is different form yours.


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29872
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2332b0eb7a2f74e8178b95a23c8ac2091027a071
Gerrit-Change-Number: 29872
Gerrit-PatchSet: 2
Gerrit-Owner: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Ren Kuo <ren.kuo at quanta.corp-partner.google.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan at google.com>
Gerrit-Comment-Date: Thu, 29 Nov 2018 02:50:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181129/41f733e7/attachment.html>


More information about the coreboot-gerrit mailing list