[coreboot-gerrit] Change in ...coreboot[master]: mb/poppy/variant/nami: Move FPMCU_INT_L gpios to B group

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29872 )

Change subject: mb/poppy/variant/nami: Move FPMCU_INT_L gpios to B group
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/29872/2/src/mainboard/google/poppy/variants/nami/gpio.c 
File src/mainboard/google/poppy/variants/nami/gpio.c:

https://review.coreboot.org/#/c/29872/2/src/mainboard/google/poppy/variants/nami/gpio.c@413 
PS2, Line 413: PAD_CFG_GPI_APIC
> Yes, I tried PAD_CFG_GPI_APIC_INVERT and I don't see the spi device and I don't see interrupts in /p […]
If you have SOC_INTEL_COMMON_BLOCK_GPIO_ITSS_POL_CFG selected in your repo for skylake, then I would expect PAD_CFG_GPI_APIC_INVERT to work as expected. One thing to check would be to assert the line manually and see what the pad input is and if you see any interrupts.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29872
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2332b0eb7a2f74e8178b95a23c8ac2091027a071
Gerrit-Change-Number: 29872
Gerrit-PatchSet: 2
Gerrit-Owner: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Ren Kuo <ren.kuo at quanta.corp-partner.google.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan at google.com>
Gerrit-Comment-Date: Wed, 28 Nov 2018 20:15:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ren Kuo <ren.kuo at quanta.corp-partner.google.com>
Comment-In-Reply-To: Shelley Chen <shchen at google.com>
Comment-In-Reply-To: Furquan Shaikh <furquan at google.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181128/804f0a26/attachment.html>