[coreboot-gerrit] Change in ...coreboot[master]: security/tpm: Move TPM2 NVRAM specific settings

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29326 )

Change subject: security/tpm: Move TPM2 NVRAM specific settings
......................................................................


Patch Set 5:

(2 comments)

https://review.coreboot.org/#/c/29326/5/src/security/tpm/tss/tcg-2.0/tss_structures.h 
File src/security/tpm/tss/tcg-2.0/tss_structures.h:

https://review.coreboot.org/#/c/29326/5/src/security/tpm/tss/tcg-2.0/tss_structures.h@161 
PS5, Line 161: 	0x94, 0x46, 0x62, 0x26, 0x68, 0x8E, 0xEE, 0xE6, 0x6A, 0xA1};
> What is this? how is this related to NVRAM?
NVRAM policy


https://review.coreboot.org/#/c/29326/5/src/security/vboot/secdata_tpm.c 
File src/security/vboot/secdata_tpm.c:

https://review.coreboot.org/#/c/29326/5/src/security/vboot/secdata_tpm.c@41 
PS5, Line 41: 
> missing include for tss_structures. […]
Already exposed through tss.h -> tspi.h



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29326
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec9d1c272ed8d0872c9bbc406e98a19ac7a376bd
Gerrit-Change-Number: 29326
Gerrit-PatchSet: 5
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Wed, 28 Nov 2018 17:16:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h at gmx.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181128/721c8854/attachment.html>