[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/common/block/acpi: fix P-States extra entry
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Tue Nov 20 14:06:54 CET 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25429 )
Change subject: soc/intel/common/block/acpi: fix P-States extra entry
......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/#/c/25429/8/src/soc/intel/common/block/acpi/acpi.c
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/#/c/25429/8/src/soc/intel/common/block/acpi/acpi.c@330
PS8, Line 330: if (((ratio_max - ratio_min) % ratio_step) > 0) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/25429/8/src/soc/intel/common/block/acpi/acpi.c@333
PS8, Line 333: if (turbo) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/25429/8/src/soc/intel/common/block/acpi/acpi.c@336
PS8, Line 336: if (num_entries > PSS_MAX_ENTRIES) {
braces {} are not necessary for single statement blocks
--
To view, visit https://review.coreboot.org/c/coreboot/+/25429
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I91090b4d87eb82b57055c24271d679d1cbb3b7a7
Gerrit-Change-Number: 25429
Gerrit-PatchSet: 8
Gerrit-Owner: Julien Viard de Galbert <coreboot-review-ju at vdg.name>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Jay Talbott <JayTalbott at sysproconsulting.com>
Gerrit-Reviewer: Julien Viard de Galbert <coreboot-review-ju at vdg.name>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 20 Nov 2018 13:06:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181120/c66ed500/attachment.html>
More information about the coreboot-gerrit
mailing list