[coreboot-gerrit] Change in ...coreboot[master]: util/inteltool: Add Apollo Lake GPIO groups and names

Wed Nov 28 16:20:36 CET 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29897 )

Change subject: util/inteltool: Add Apollo Lake GPIO groups and names
......................................................................

Patch Set 1:

(24 comments)

https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c 
File util/inteltool/gpio_groups.c:

https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@108 
PS1, Line 108: 	"*GPIO_72",	"GP_CAMERASB10","n/a",	"n/a",	"n/a",	"n/a",
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@109 
PS1, Line 109: 	"*GPIO_73",	"GP_CAMERASB11","n/a",	"n/a",	"n/a",	"n/a",
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@116 
PS1, Line 116: 	"JTAGX"	,	"*JTAGX",	"n/a",	"n/a",	"n/a",	"n/a",
space prohibited before that ',' (ctx:WxW)

https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@123 
PS1, Line 123: 	"SVID0_ALERT_B","*SVID0_ALERT_N","n/a",	"n/a",	"n/a",	"n/a",
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@123 
PS1, Line 123: 	"SVID0_ALERT_B","*SVID0_ALERT_N","n/a",	"n/a",	"n/a",	"n/a",
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@167 
PS1, Line 167: 	"PMC_SPI_FS2",	 "*PMC_SPI_FS2",	"FST_SPI_CS2_N","n/a",
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@181 
PS1, Line 181: 	"*GPIO_74",	 "AVS_I2S1_MCLK" ,	"n/a",		"n/a",
space prohibited before that ',' (ctx:WxW)

https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@186 
PS1, Line 186: 	"*GPIO_79",	 "AVS_DMIC_CLK_A1",	"AVS_I2S4_BCLK","n/a",
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@187 
PS1, Line 187: 	"*GPIO_80",	 "AVS_DMIC_CLK_B1",	"AVS_I2S4_WS_SYNC","n/a",
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@191 
PS1, Line 191: 	"*GPIO_84",	 "AVS_I2S2_MCLK",	"AVS_HDA_RST_N","n/a",
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@319 
PS1, Line 319: 	"*GPIO_134",	"LPSS_I2C5_SDA","ISH_I2C0_SDA",		"n/a",
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@320 
PS1, Line 320: 	"*GPIO_135",	"LPSS_I2C5_SCL","ISH_I2C0_SCL",		"n/a",
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@321 
PS1, Line 321: 	"*GPIO_136",	"LPSS_I2C6_SDA","ISH_I2C1_SDA",		"n/a",
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@322 
PS1, Line 322: 	"*GPIO_137",	"LPSS_I2C6_SCL","ISH_I2C1_SCL",		"n/a",
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@323 
PS1, Line 323: 	"*GPIO_138",	"LPSS_I2C7_SDA","ISH_I2C2_SDA",		"n/a",
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@324 
PS1, Line 324: 	"*GPIO_139",	"LPSS_I2C7_SCL","ISH_I2C2_SCL",		"n/a",
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@335 
PS1, Line 335: 	"GPIO_209",	"*PCIE_CLKREQ0_N",	"MODEM_CLK_REQ","n/a",
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@339 
PS1, Line 339: 	"OSC_CLK_OUT_0","*OSC_CLK_OUT_0",	"n/a",		"n/a",
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@340 
PS1, Line 340: 	"OSC_CLK_OUT_1","*OSC_CLK_OUT_1",	"n/a",		"n/a",
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@341 
PS1, Line 341: 	"OSC_CLK_OUT_2","*OSC_CLK_OUT_2",	"n/a",		"n/a",
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@342 
PS1, Line 342: 	"OSC_CLK_OUT_3","*OSC_CLK_OUT_3",	"n/a",		"n/a",
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@343 
PS1, Line 343: 	"OSC_CLK_OUT_4","*OSC_CLK_OUT_4",	"n/a",		"n/a",
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@344 
PS1, Line 344: 	"*PMU_AC_PRESENT","PMU_AC_PRESENT",	"n/a",		"n/a",
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@353 
PS1, Line 353: 	"*PMU_WAKE_B",	"PMU_WAKE_B/EMMC_PWR_EN_N","n/a",	"n/a",
space required after that ',' (ctx:VxV)

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29897
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5cd687fdc1d2ae81f2e948178bf319897b47f031
Gerrit-Change-Number: 29897
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 28 Nov 2018 15:20:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181128/8af78365/attachment.html>