<p><a href="https://review.coreboot.org/c/coreboot/+/29897">View Change</a></p><p>24 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c">File util/inteltool/gpio_groups.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@108">Patch Set #1, Line 108:</a> <code style="font-family:monospace,monospace"> "*GPIO_72", "GP_CAMERASB10","n/a", "n/a", "n/a", "n/a",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@109">Patch Set #1, Line 109:</a> <code style="font-family:monospace,monospace"> "*GPIO_73", "GP_CAMERASB11","n/a", "n/a", "n/a", "n/a",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@116">Patch Set #1, Line 116:</a> <code style="font-family:monospace,monospace"> "JTAGX" , "*JTAGX", "n/a", "n/a", "n/a", "n/a",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxW)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@123">Patch Set #1, Line 123:</a> <code style="font-family:monospace,monospace"> "SVID0_ALERT_B","*SVID0_ALERT_N","n/a", "n/a", "n/a", "n/a",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@123">Patch Set #1, Line 123:</a> <code style="font-family:monospace,monospace"> "SVID0_ALERT_B","*SVID0_ALERT_N","n/a", "n/a", "n/a", "n/a",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@167">Patch Set #1, Line 167:</a> <code style="font-family:monospace,monospace"> "PMC_SPI_FS2", "*PMC_SPI_FS2", "FST_SPI_CS2_N","n/a",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@181">Patch Set #1, Line 181:</a> <code style="font-family:monospace,monospace"> "*GPIO_74", "AVS_I2S1_MCLK" , "n/a", "n/a",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxW)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@186">Patch Set #1, Line 186:</a> <code style="font-family:monospace,monospace"> "*GPIO_79", "AVS_DMIC_CLK_A1", "AVS_I2S4_BCLK","n/a",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@187">Patch Set #1, Line 187:</a> <code style="font-family:monospace,monospace"> "*GPIO_80", "AVS_DMIC_CLK_B1", "AVS_I2S4_WS_SYNC","n/a",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@191">Patch Set #1, Line 191:</a> <code style="font-family:monospace,monospace"> "*GPIO_84", "AVS_I2S2_MCLK", "AVS_HDA_RST_N","n/a",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@319">Patch Set #1, Line 319:</a> <code style="font-family:monospace,monospace"> "*GPIO_134", "LPSS_I2C5_SDA","ISH_I2C0_SDA", "n/a",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@320">Patch Set #1, Line 320:</a> <code style="font-family:monospace,monospace"> "*GPIO_135", "LPSS_I2C5_SCL","ISH_I2C0_SCL", "n/a",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@321">Patch Set #1, Line 321:</a> <code style="font-family:monospace,monospace"> "*GPIO_136", "LPSS_I2C6_SDA","ISH_I2C1_SDA", "n/a",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@322">Patch Set #1, Line 322:</a> <code style="font-family:monospace,monospace"> "*GPIO_137", "LPSS_I2C6_SCL","ISH_I2C1_SCL", "n/a",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@323">Patch Set #1, Line 323:</a> <code style="font-family:monospace,monospace"> "*GPIO_138", "LPSS_I2C7_SDA","ISH_I2C2_SDA", "n/a",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@324">Patch Set #1, Line 324:</a> <code style="font-family:monospace,monospace"> "*GPIO_139", "LPSS_I2C7_SCL","ISH_I2C2_SCL", "n/a",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@335">Patch Set #1, Line 335:</a> <code style="font-family:monospace,monospace"> "GPIO_209", "*PCIE_CLKREQ0_N", "MODEM_CLK_REQ","n/a",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@339">Patch Set #1, Line 339:</a> <code style="font-family:monospace,monospace"> "OSC_CLK_OUT_0","*OSC_CLK_OUT_0", "n/a", "n/a",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@340">Patch Set #1, Line 340:</a> <code style="font-family:monospace,monospace"> "OSC_CLK_OUT_1","*OSC_CLK_OUT_1", "n/a", "n/a",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@341">Patch Set #1, Line 341:</a> <code style="font-family:monospace,monospace"> "OSC_CLK_OUT_2","*OSC_CLK_OUT_2", "n/a", "n/a",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@342">Patch Set #1, Line 342:</a> <code style="font-family:monospace,monospace"> "OSC_CLK_OUT_3","*OSC_CLK_OUT_3", "n/a", "n/a",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@343">Patch Set #1, Line 343:</a> <code style="font-family:monospace,monospace"> "OSC_CLK_OUT_4","*OSC_CLK_OUT_4", "n/a", "n/a",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@344">Patch Set #1, Line 344:</a> <code style="font-family:monospace,monospace"> "*PMU_AC_PRESENT","PMU_AC_PRESENT", "n/a", "n/a",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29897/1/util/inteltool/gpio_groups.c@353">Patch Set #1, Line 353:</a> <code style="font-family:monospace,monospace"> "*PMU_WAKE_B", "PMU_WAKE_B/EMMC_PWR_EN_N","n/a", "n/a",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/29897">change 29897</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/29897"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5cd687fdc1d2ae81f2e948178bf319897b47f031 </div>
<div style="display:none"> Gerrit-Change-Number: 29897 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 28 Nov 2018 15:20:36 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>