[coreboot-gerrit] Change in ...coreboot[master]: util/inteltool: Add Apollo Lake LPC ID and allow to read PCRs

[Nico Huber (Code Review)]

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29896


Change subject: util/inteltool: Add Apollo Lake LPC ID and allow to read PCRs
......................................................................

util/inteltool: Add Apollo Lake LPC ID and allow to read PCRs

The P2SB (PCI to Side-Band) bridge is on a different PCI device on APL.
Hence, we have to decide based on the LPC ID which device to query.

Also fix a comment.

Change-Id: Ie20d7d2d246629d085bcf4740ba28b1e81e6a12a
Signed-off-by: Nico Huber <nico.huber at secunet.com>
---
M util/inteltool/inteltool.c
M util/inteltool/inteltool.h
M util/inteltool/pcr.c
3 files changed, 31 insertions(+), 3 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/29896/1

diff --git a/util/inteltool/inteltool.c b/util/inteltool/inteltool.c
index d0b4279..6966915 100644
--- a/util/inteltool/inteltool.c
+++ b/util/inteltool/inteltool.c
@@ -247,6 +247,7 @@
 	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C224, "C224"},
 	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C226, "C226"},
 	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_H81, "H81"},
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_APL_LPC, "Apollo Lake" },
 	/* Intel GPUs */
 	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_G35_EXPRESS,
 	  "Intel(R) G35 Express Chipset Family" },
diff --git a/util/inteltool/inteltool.h b/util/inteltool/inteltool.h
index 5de73aa..f232135 100644
--- a/util/inteltool/inteltool.h
+++ b/util/inteltool/inteltool.h
@@ -227,6 +227,8 @@
 #define PCI_DEVICE_ID_INTEL_BAYTRAIL_GFX	0x0f31
 #define CPUID_BAYTRAIL						0x30670
 
+#define PCI_DEVICE_ID_INTEL_APL_LPC		0x5ae8
+
 /* Intel starts counting these generations with the integration of the DRAM controller */
 #define PCI_DEVICE_ID_INTEL_CORE_0TH_GEN	0xd132 /* Nehalem */
 #define PCI_DEVICE_ID_INTEL_CORE_1ST_GEN	0x0044 /* Westmere */
diff --git a/util/inteltool/pcr.c b/util/inteltool/pcr.c
index 7223e19..4e75905 100644
--- a/util/inteltool/pcr.c
+++ b/util/inteltool/pcr.c
@@ -70,11 +70,36 @@
 {
 	bool error_exit = false;
 	bool p2sb_revealed = false;
+	struct pci_dev *p2sb;
 
 	if (sbbar)
 		return;
 
-	struct pci_dev *const p2sb = pci_get_dev(sb->access, 0, 0, 0x1f, 1);
+	switch (sb->device_id) {
+	case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_PRE:
+	case PCI_DEVICE_ID_INTEL_H110:
+	case PCI_DEVICE_ID_INTEL_H170:
+	case PCI_DEVICE_ID_INTEL_Z170:
+	case PCI_DEVICE_ID_INTEL_Q170:
+	case PCI_DEVICE_ID_INTEL_Q150:
+	case PCI_DEVICE_ID_INTEL_B150:
+	case PCI_DEVICE_ID_INTEL_C236:
+	case PCI_DEVICE_ID_INTEL_C232:
+	case PCI_DEVICE_ID_INTEL_QM170:
+	case PCI_DEVICE_ID_INTEL_HM170:
+	case PCI_DEVICE_ID_INTEL_CM236:
+	case PCI_DEVICE_ID_INTEL_HM175:
+	case PCI_DEVICE_ID_INTEL_QM175:
+	case PCI_DEVICE_ID_INTEL_CM238:
+		p2sb = pci_get_dev(sb->access, 0, 0, 0x1f, 1);
+		break;
+	case PCI_DEVICE_ID_INTEL_APL_LPC:
+		p2sb = pci_get_dev(sb->access, 0, 0, 0x0d, 0);
+		break;
+	default:
+		perror("Unknown LPC device.");
+		exit(1);
+	}
 
 	if (!p2sb) {
 		perror("Can't allocate device node for P2SB.");
@@ -86,8 +111,8 @@
 	if (p2sb->vendor_id == 0xffff && p2sb->device_id == 0xffff) {
 		printf("Trying to reveal Primary to Sideband Bridge "
 		       "(P2SB),\nlet's hope the OS doesn't mind... ");
-		/* Do not use pci_write_long(). Surrounding
-		   bytes 0xe0 must be maintained. */
+		/* Do not use pci_write_long(). Bytes
+		   surrounding 0xe0 must be maintained. */
 		pci_write_byte(p2sb, 0xe0 + 1, 0);
 
 		pci_fill_info(p2sb, PCI_FILL_IDENT | PCI_FILL_RESCAN);

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29896
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie20d7d2d246629d085bcf4740ba28b1e81e6a12a
Gerrit-Change-Number: 29896
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181128/b0731a6a/attachment-0001.html>