[coreboot-gerrit] Change in ...coreboot[master]: soc/{amd, intel}: Remove duplicated '&' on ptr's function

[David Guckian (Code Review)]

David Guckian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29862 )

Change subject: soc/{amd,intel}: Remove duplicated '&' on ptr's function
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

You can include denverton_ns/systemagent.c if you wish.
But I think the ops structures need the &

https://review.coreboot.org/#/c/29862/1/src/soc/intel/denverton_ns/systemagent.c 
File src/soc/intel/denverton_ns/systemagent.c:

https://review.coreboot.org/#/c/29862/1/src/soc/intel/denverton_ns/systemagent.c@342 
PS1, Line 342: 	.ops_pci = &soc_pci_ops,
soc_pci_ops is a structure not a function, it requires the &


https://review.coreboot.org/#/c/29862/1/src/soc/intel/denverton_ns/systemagent.c@353 
PS1, Line 353: 	.ops = &systemagent_ops,
Here too, systemagent_ops is a structure not a function, requires the &



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29862
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7a59fd2f370d2b0d830ca83be9a9bc1abe2750f5
Gerrit-Change-Number: 29862
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian <david.guckian at intel.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 27 Nov 2018 12:10:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181127/a5b28459/attachment.html>