<p style="white-space: pre-wrap; word-wrap: break-word;">You can include denverton_ns/systemagent.c if you wish.<br>But I think the ops structures need the &</p><p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://review.coreboot.org/c/coreboot/+/29862">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29862/1/src/soc/intel/denverton_ns/systemagent.c">File src/soc/intel/denverton_ns/systemagent.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29862/1/src/soc/intel/denverton_ns/systemagent.c@342">Patch Set #1, Line 342:</a> <code style="font-family:monospace,monospace">       .ops_pci = &soc_pci_ops,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">soc_pci_ops is a structure not a function, it requires the &</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29862/1/src/soc/intel/denverton_ns/systemagent.c@353">Patch Set #1, Line 353:</a> <code style="font-family:monospace,monospace">     .ops = &systemagent_ops,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Here too, systemagent_ops is a structure not a function, requires the &</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/29862">change 29862</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/29862"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7a59fd2f370d2b0d830ca83be9a9bc1abe2750f5 </div>
<div style="display:none"> Gerrit-Change-Number: 29862 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: David Guckian </div>
<div style="display:none"> Gerrit-Reviewer: David Guckian <david.guckian@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 27 Nov 2018 12:10:25 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>