[coreboot-gerrit] Change in ...coreboot[master]: cheza: Add board reset via Chrome EC

Julius Werner (Code Review) gerrit at coreboot.org
Tue Nov 27 02:56:35 CET 2018


Hello build bot (Jenkins), Patrick Georgi, Martin Roth, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/29849

to look at the new patch set (#2).

Change subject: cheza: Add board reset via Chrome EC
......................................................................

cheza: Add board reset via Chrome EC

This patch implements board reset on the Cheza board. The real board
reset used by the operating system uses the PMIC, but unfortunately the
PMIC needs to be configured right for that to work. The PMIC
configuration currently happens in the Qualcomm blob (QcLib) that is run
from romstage, but vboot needs to be able to reboot during verstage
already. Porting all the PMIC initialization code to run in the
bootblock seems excessive (and at odds with the goal of doing as little
as possible before verification), so we'll just do a little hack and ask
the EC to perform a cold reset instead. For vboot purposes, this should
work just as well.

BUG=b:118501305
TEST=Hacked vboot code to call vboot_reboot(), confirmed that board
reset and came back up as expected.

Change-Id: I3858d95f481884a87c243d4fa3d6369c1e8a5a2c
Signed-off-by: Julius Werner <jwerner at chromium.org>
---
M src/mainboard/google/cheza/Kconfig
M src/mainboard/google/cheza/Makefile.inc
A src/mainboard/google/cheza/reset.c
3 files changed, 28 insertions(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/29849/2
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29849
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3858d95f481884a87c243d4fa3d6369c1e8a5a2c
Gerrit-Change-Number: 29849
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181127/0aa24d48/attachment.html>


More information about the coreboot-gerrit mailing list