[coreboot-gerrit] Change in ...coreboot[master]: cheza: Add board reset via Chrome EC

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Tue Nov 27 02:29:06 CET 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29849 )

Change subject: cheza: Add board reset via Chrome EC
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/29849/1/src/mainboard/google/cheza/reset.c 
File src/mainboard/google/cheza/reset.c:

https://review.coreboot.org/#/c/29849/1/src/mainboard/google/cheza/reset.c@21 
PS1, Line 21: void do_board_reset(void) {
open brace '{' following function definitions go on the next line



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29849
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3858d95f481884a87c243d4fa3d6369c1e8a5a2c
Gerrit-Change-Number: 29849
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 27 Nov 2018 01:29:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181127/65ea306f/attachment.html>


More information about the coreboot-gerrit mailing list