[coreboot-gerrit] Change in ...coreboot[master]: src/mb/pcengines/apu2/mainboard.c: Fix retrieving serial number

Michał Żygowski (Code Review) gerrit at coreboot.org
Mon Nov 26 20:04:13 CET 2018


Hello Piotr Król, build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/29842

to look at the new patch set (#2).

Change subject: src/mb/pcengines/apu2/mainboard.c: Fix retrieving serial number
......................................................................

src/mb/pcengines/apu2/mainboard.c: Fix retrieving serial number

Handle situation when first NIC is not BDF 1:0.0. The PCI enumeration
is different when a external PCIe device is connected to mPCIe2 slot
which is routed to first PCIe bridge. The first NIC is then assigned
BDF 2:0.0, because it is connected to the second PCIe bridge.

Add a check for vendor ID and device ID of the NIC, before reading
MAC address and calculating serial number.

Change-Id: I9f89a6f3cd0c23a2d2924e587338f69c260b12f8
Signed-off-by: Michał Żygowski <michal.zygowski at 3mdeb.com>
---
M src/mainboard/pcengines/apu2/mainboard.c
1 file changed, 28 insertions(+), 0 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/29842/2
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29842
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f89a6f3cd0c23a2d2924e587338f69c260b12f8
Gerrit-Change-Number: 29842
Gerrit-PatchSet: 2
Gerrit-Owner: Michał Żygowski <michal.zygowski at 3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski at 3mdeb.com>
Gerrit-Reviewer: Piotr Król <piotr.krol at 3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181126/6726c174/attachment.html>


More information about the coreboot-gerrit mailing list