[coreboot-gerrit] Change in ...coreboot[master]: x86/acpi: Add Kconfig to toggle 8259 reporting

[Nico Huber (Code Review)]

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29832


Change subject: x86/acpi: Add Kconfig to toggle 8259 reporting
......................................................................

x86/acpi: Add Kconfig to toggle 8259 reporting

Change-Id: If3c9783ebc41c103c915788139d91644b805f397
Signed-off-by: Nico Huber <nico.h at gmx.de>
---
M src/arch/x86/Kconfig
M src/arch/x86/acpi.c
2 files changed, 10 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/29832/1

diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig
index 7c8371e..2a16caa 100644
--- a/src/arch/x86/Kconfig
+++ b/src/arch/x86/Kconfig
@@ -277,6 +277,14 @@
 	  Note that it is the responsibility of the payload to reset the
 	  normal boot bit to 1 after each successsful boot.
 
+config ACPI_NO_PCAT_8259
+	bool
+	help
+	  Selected by platforms that don't expose a PC/AT 8259 PIC pair.
+
+config ACPI_HAVE_PCAT_8259
+	def_bool y if !ACPI_NO_PCAT_8259
+
 config ACPI_CPU_STRING
 	string
 	default "\\_PR.CP%02d"
diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c
index 3b33f1b..848b509 100644
--- a/src/arch/x86/acpi.c
+++ b/src/arch/x86/acpi.c
@@ -220,7 +220,8 @@
 	header->revision = get_acpi_table_revision(MADT);
 
 	madt->lapic_addr = LOCAL_APIC_ADDR;
-	madt->flags = 0x1; /* PCAT_COMPAT */
+	if (IS_ENABLED(CONFIG_ACPI_HAVE_PCAT_8259))
+		madt->flags |= 1;
 
 	current = acpi_fill_madt(current);
 

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29832
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3c9783ebc41c103c915788139d91644b805f397
Gerrit-Change-Number: 29832
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181126/24c993ff/attachment.html>