[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/apl/acpi: Do not report 8259 PICs

[Nico Huber (Code Review)]

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29833


Change subject: soc/intel/apl/acpi: Do not report 8259 PICs
......................................................................

soc/intel/apl/acpi: Do not report 8259 PICs

The IRQ tables don't support this path, so we shouldn't report presence
of the legacy PICs. As the _PIC method is optional and we ignore the
passed parameter anyway, drop it.

Change-Id: I51301a600e16f74fde00fdcb4595e1f47a52e207
Signed-off-by: Nico Huber <nico.h at gmx.de>
---
M src/soc/intel/apollolake/Kconfig
M src/soc/intel/apollolake/acpi/platform.asl
2 files changed, 1 insertion(+), 16 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/29833/1

diff --git a/src/soc/intel/apollolake/Kconfig b/src/soc/intel/apollolake/Kconfig
index 4a841be..6571892 100644
--- a/src/soc/intel/apollolake/Kconfig
+++ b/src/soc/intel/apollolake/Kconfig
@@ -20,6 +20,7 @@
 config CPU_SPECIFIC_OPTIONS
 	def_bool y
 	select ACPI_INTEL_HARDWARE_SLEEP_VALUES
+	select ACPI_NO_PCAT_8259
 	select ARCH_BOOTBLOCK_X86_32
 	select ARCH_RAMSTAGE_X86_32
 	select ARCH_ROMSTAGE_X86_32
diff --git a/src/soc/intel/apollolake/acpi/platform.asl b/src/soc/intel/apollolake/acpi/platform.asl
index ec1844a..f3202a0 100644
--- a/src/soc/intel/apollolake/acpi/platform.asl
+++ b/src/soc/intel/apollolake/acpi/platform.asl
@@ -18,19 +18,3 @@
 /* Enable ACPI _SWS methods */
 #include <soc/intel/common/acpi/acpi_wake_source.asl>
 #include <soc/intel/common/acpi/platform.asl>
-
-Name(\PICM, Zero) // IOAPIC/8259
-
-/*
- * The _PIC method is called by the OS to choose between interrupt
- * routing via the i8259 interrupt controller or the APIC.
- *
- * _PIC is called with a parameter of 0 for i8259 configuration and
- * with a parameter of 1 for Local Apic/IOAPIC configuration.
- */
-
-Method (_PIC, 1)
-{
-	/* Remember the OS' IRQ routing choice. */
-	Store (Arg0, PICM)
-}

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29833
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51301a600e16f74fde00fdcb4595e1f47a52e207
Gerrit-Change-Number: 29833
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181126/43c7ff47/attachment-0001.html>