[coreboot-gerrit] Change in ...coreboot[master]: mainboard/lenovo/t530: Improve configuration

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29816 )

Change subject: mainboard/lenovo/t530: Improve configuration
......................................................................


Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/29816/2/src/mainboard/lenovo/t530/Kconfig 
File src/mainboard/lenovo/t530/Kconfig:

https://review.coreboot.org/#/c/29816/2/src/mainboard/lenovo/t530/Kconfig@41 
PS2, Line 41: 0x2a
> Would be great to make cmos. […]
so basically move it to mainboard/lenovo?


https://review.coreboot.org/#/c/29816/2/src/mainboard/lenovo/t530/Kconfig@95 
PS2, Line 95: config CBFS_SIZE
            : 	hex
            : 	default 0x001d9000 if VBOOT
            : 	default 0x0069b800
> Is this even used when using an FMDFILE? I thought it was only used to generate a default FMD?
AFAIK it should be used



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29816
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28c2fb92d574c8070dbf767adc5839faf4fb47a0
Gerrit-Change-Number: 29816
Gerrit-PatchSet: 3
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Comment-Date: Fri, 23 Nov 2018 19:23:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181123/88b317d9/attachment.html>