[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/common: Bring DISPLAY_MTRRS into the light

[Nico Huber (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/29684

to look at the new patch set (#4).

Change subject: soc/intel/common: Bring DISPLAY_MTRRS into the light
......................................................................

soc/intel/common: Bring DISPLAY_MTRRS into the light

Initially, I wanted to move only the Kconfig DISPLAY_MTRRS into the
"Debug" menu. It turned out, though, that the code looks rather generic
and while it's not perfect, I see nothing to be ashamed of. No need to
hide it in soc/intel/.

To not bloat src/Kconfig up any further, start a new `Kconfig.debug`
hierarchy just for debug options.

If somebody wants to review the code if it's 100% generic, we could
even get rid of HAVE_DISPLAY_MTRRS.

Change-Id: Ibd0a64121bd6e4ab5d7fd835f3ac25d3f5011f24
Signed-off-by: Nico Huber <nico.h at gmx.de>
---
M Documentation/Intel/Board/Galileo_checklist.html
M Documentation/Intel/SoC/soc.html
M src/Kconfig
M src/arch/x86/postcar.c
A src/cpu/x86/Kconfig.debug
M src/cpu/x86/mtrr/Makefile.inc
A src/cpu/x86/mtrr/debug.c
M src/cpu/x86/mtrr/earlymtrr.c
M src/drivers/intel/fsp1_1/after_raminit.S
M src/drivers/intel/fsp1_1/car.c
M src/drivers/intel/fsp1_1/include/fsp/ramstage.h
M src/drivers/intel/fsp1_1/include/fsp/romstage.h
M src/drivers/intel/fsp1_1/stack.c
M src/drivers/intel/fsp2_0/debug.c
M src/drivers/intel/fsp2_0/notify.c
M src/include/cpu/x86/mtrr.h
M src/soc/intel/common/Kconfig
M src/soc/intel/common/Makefile.inc
D src/soc/intel/common/util.c
D src/soc/intel/common/util.h
M src/soc/intel/quark/Makefile.inc
M src/soc/intel/quark/bootblock/bootblock.c
M src/soc/intel/quark/include/soc/ramstage.h
M src/soc/intel/quark/romstage/mtrr.c
M src/vendorcode/intel/fsp/fsp1_1/checklist/romstage_complete.dat
M src/vendorcode/intel/fsp/fsp1_1/checklist/romstage_optional.dat
M src/vendorcode/intel/fsp/fsp1_1/checklist/verstage_complete.dat
M src/vendorcode/intel/fsp/fsp1_1/checklist/verstage_optional.dat
28 files changed, 251 insertions(+), 313 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/29684/4
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29684
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd0a64121bd6e4ab5d7fd835f3ac25d3f5011f24
Gerrit-Change-Number: 29684
Gerrit-PatchSet: 4
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Julius Werner <jwerner at chromium.org>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181122/2732f54d/attachment.html>