[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/common: Bring DISPLAY_MTRRS into the light

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29684 )

Change subject: soc/intel/common: Bring DISPLAY_MTRRS into the light
......................................................................


Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/29684/3/src/cpu/Kconfig.debug 
File src/cpu/Kconfig.debug:

https://review.coreboot.org/#/c/29684/3/src/cpu/Kconfig.debug@1 
PS3, Line 1: source "src/cpu/*/Kconfig.debug"
nit: maybe just put this line directly into src/Kconfig?


https://review.coreboot.org/#/c/29684/3/src/cpu/x86/Kconfig.debug 
File src/cpu/x86/Kconfig.debug:

https://review.coreboot.org/#/c/29684/3/src/cpu/x86/Kconfig.debug@1 
PS3, Line 1: config HAVE_DISPLAY_MTRRS
Shouldn't this whole file have an if ARCH_X86 wrapped around it? (Then again, I'm asking myself the same thing about src/cpu/x86/Kconfig... and why *is* there an if ARCH_X86 with a bunch of x86-specific crap in src/cpu/Kconfig?)



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29684
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd0a64121bd6e4ab5d7fd835f3ac25d3f5011f24
Gerrit-Change-Number: 29684
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Julius Werner <jwerner at chromium.org>
Gerrit-Comment-Date: Wed, 21 Nov 2018 01:11:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181121/fb5b4856/attachment.html>