[coreboot-gerrit] Change in ...coreboot[master]: siemens/mc_apl1/variants/mc_apl*: Remove unneeded PTN read

[Mario Scheithauer (Code Review)]

Mario Scheithauer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29799


Change subject: siemens/mc_apl1/variants/mc_apl*: Remove unneeded PTN read
......................................................................

siemens/mc_apl1/variants/mc_apl*: Remove unneeded PTN read

An additional reading of PTN configuration data at the end of the
ptn3460_init function is not necessary.

Change-Id: I5f7f647242e94b1af13757d00e80ed9813d435d0
Signed-off-by: Mario Scheithauer <mario.scheithauer at siemens.com>
---
M src/mainboard/siemens/mc_apl1/variants/mc_apl1/ptn3460.c
M src/mainboard/siemens/mc_apl1/variants/mc_apl5/ptn3460.c
2 files changed, 0 insertions(+), 12 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/29799/1

diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/ptn3460.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/ptn3460.c
index e95b752..060a35c 100644
--- a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/ptn3460.c
+++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/ptn3460.c
@@ -109,12 +109,6 @@
 			return (PTN_BUS_ERROR | status);
 	}
 
-	/* Read PTN configuration data. */
-	status = i2c_read_bytes(PTN_I2C_CONTROLLER, PTN_SLAVE_ADR,
-			PTN_CONFIG_OFF, (uint8_t *)&cfg, sizeof(cfg));
-	if (status)
-		return (PTN_BUS_ERROR | status);
-
 	return PTN_NO_ERROR;
 }
 
diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/ptn3460.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/ptn3460.c
index 829af2a..01da624 100644
--- a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/ptn3460.c
+++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/ptn3460.c
@@ -110,12 +110,6 @@
 			return (PTN_BUS_ERROR | status);
 	}
 
-	/* Read PTN configuration data. */
-	status = i2c_read_bytes(PTN_I2C_CONTROLLER, PTN_SLAVE_ADR,
-			PTN_CONFIG_OFF, (uint8_t *)&cfg, sizeof(cfg));
-	if (status)
-		return (PTN_BUS_ERROR | status);
-
 	return PTN_NO_ERROR;
 }
 

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29799
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f7f647242e94b1af13757d00e80ed9813d435d0
Gerrit-Change-Number: 29799
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181122/fbd7a15f/attachment.html>