<p>Mario Scheithauer has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/29799">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">siemens/mc_apl1/variants/mc_apl*: Remove unneeded PTN read<br><br>An additional reading of PTN configuration data at the end of the<br>ptn3460_init function is not necessary.<br><br>Change-Id: I5f7f647242e94b1af13757d00e80ed9813d435d0<br>Signed-off-by: Mario Scheithauer <mario.scheithauer@siemens.com><br>---<br>M src/mainboard/siemens/mc_apl1/variants/mc_apl1/ptn3460.c<br>M src/mainboard/siemens/mc_apl1/variants/mc_apl5/ptn3460.c<br>2 files changed, 0 insertions(+), 12 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/29799/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/ptn3460.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/ptn3460.c</span><br><span>index e95b752..060a35c 100644</span><br><span>--- a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/ptn3460.c</span><br><span>+++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/ptn3460.c</span><br><span>@@ -109,12 +109,6 @@</span><br><span>                  return (PTN_BUS_ERROR | status);</span><br><span>     }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   /* Read PTN configuration data. */</span><br><span style="color: hsl(0, 100%, 40%);">-      status = i2c_read_bytes(PTN_I2C_CONTROLLER, PTN_SLAVE_ADR,</span><br><span style="color: hsl(0, 100%, 40%);">-                      PTN_CONFIG_OFF, (uint8_t *)&cfg, sizeof(cfg));</span><br><span style="color: hsl(0, 100%, 40%);">-      if (status)</span><br><span style="color: hsl(0, 100%, 40%);">-             return (PTN_BUS_ERROR | status);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>     return PTN_NO_ERROR;</span><br><span> }</span><br><span> </span><br><span>diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/ptn3460.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/ptn3460.c</span><br><span>index 829af2a..01da624 100644</span><br><span>--- a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/ptn3460.c</span><br><span>+++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/ptn3460.c</span><br><span>@@ -110,12 +110,6 @@</span><br><span>                    return (PTN_BUS_ERROR | status);</span><br><span>     }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   /* Read PTN configuration data. */</span><br><span style="color: hsl(0, 100%, 40%);">-      status = i2c_read_bytes(PTN_I2C_CONTROLLER, PTN_SLAVE_ADR,</span><br><span style="color: hsl(0, 100%, 40%);">-                      PTN_CONFIG_OFF, (uint8_t *)&cfg, sizeof(cfg));</span><br><span style="color: hsl(0, 100%, 40%);">-      if (status)</span><br><span style="color: hsl(0, 100%, 40%);">-             return (PTN_BUS_ERROR | status);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>     return PTN_NO_ERROR;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/29799">change 29799</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/29799"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5f7f647242e94b1af13757d00e80ed9813d435d0 </div>
<div style="display:none"> Gerrit-Change-Number: 29799 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Mario Scheithauer <mario.scheithauer@siemens.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>