[coreboot-gerrit] Change in ...coreboot[master]: mb/google/dragonegg: Add initial mainboard code support

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29749 )

Change subject: mb/google/dragonegg: Add initial mainboard code support
......................................................................


Patch Set 9:

(3 comments)

https://review.coreboot.org/#/c/29749/9/src/mainboard/google/dragonegg/dsdt.asl 
File src/mainboard/google/dragonegg/dsdt.asl:

https://review.coreboot.org/#/c/29749/9/src/mainboard/google/dragonegg/dsdt.asl@22 
PS9, Line 22: 0x05
> the revision is 0x02
Although there is no harm to declare this value as 0x5 :)
but still i will make this as 0x02 as you have asked.

here is the recommendation from spec

"A revision field value greater than or equal to 2 signifies that integers declared within the Definition Block are to be evaluated as 64 bit values"


https://review.coreboot.org/#/c/29749/9/src/mainboard/google/dragonegg/romstage_fsp_params.c 
File src/mainboard/google/dragonegg/romstage_fsp_params.c:

https://review.coreboot.org/#/c/29749/9/src/mainboard/google/dragonegg/romstage_fsp_params.c@23 
PS9, Line 23: void mainboard_memory_init_params(FSPM_UPD *mupd)
> Can this file be removed, since it contains 1 empty function only?
We can't remove this file because we might have some overrides as epatch which will apply over this file during chromium build.


https://review.coreboot.org/#/c/29749/9/src/mainboard/google/dragonegg/spd/empty.spd.hex 
File src/mainboard/google/dragonegg/spd/empty.spd.hex:

https://review.coreboot.org/#/c/29749/9/src/mainboard/google/dragonegg/spd/empty.spd.hex@1 
PS9, Line 1: 00 
> Why this empty spd file? Remove it if not used
make sense



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29749
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2cc269cb0050bf5b031f48cfe114485c55ab8fa9
Gerrit-Change-Number: 29749
Gerrit-PatchSet: 9
Gerrit-Owner: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Frans Hendriks <fhendriks at eltan.com>
Gerrit-CC: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Comment-Date: Thu, 22 Nov 2018 08:47:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes <ehaouas at noos.fr>
Comment-In-Reply-To: Frans Hendriks <fhendriks at eltan.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181122/cb04aaff/attachment.html>